Skip to content

[SYCL][ESIMD] Enable type rewriting in spirv writer adaptor #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SYCL][ESIMD] Enable type rewriting in spirv writer adaptor #2718

wants to merge 1 commit into from

Conversation

asi-sc
Copy link
Contributor

@asi-sc asi-sc commented Nov 2, 2020

No description provided.

premanandrao
premanandrao reviewed Nov 2, 2020
View reviewed changes
clang/lib/CodeGen/BackendUtil.cpp
@@ -942,7 +942,8 @@ void EmitAssemblyHelper::EmitAssembly(BackendAction Action,
PerModulePasses.add(createDeadArgEliminationSYCLPass());

if (LangOpts.SYCLIsDevice && LangOpts.SYCLExplicitSIMD)
PerModulePasses.add(createGenXSPIRVWriterAdaptorPass());
PerModulePasses.add(
createGenXSPIRVWriterAdaptorPass(/*RewriteTypes=*/true));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not entirely sure what this change does. Can you provide some details in the commit description?
Please add an appropriate test as well.

Copy link
Contributor

@Fznamznon Fznamznon Nov 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it would be great to have some context here. Although I'm not sure if front-end test is required. I think this thing enables some functionality of the GenXSPIRVWriterAdaptorPass which is likely already tested by LIT suite for this particular pass.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll add some details in the next iteration of this change. We've realized that an additional change in vc-intrinsics (library where GenXSPIRVAdaptorPass comes from) is required. So, I mark the pull request as a draft for now.

@asi-sc asi-sc marked this pull request as draft November 3, 2020 10:46
@asi-sc
Copy link
Contributor Author

asi-sc commented Nov 16, 2020

The approach has been changed slightly in libigc vector compute backend. This change is no longer necessary.

@asi-sc asi-sc closed this Nov 16, 2020
jsji pushed a commit that referenced this pull request Sep 21, 2024
@MrSidims @jsji
Allow short16 for ushort16 intel_sub_group_block_read/write (#2718)
ba7e37b 
Per cl_intel_subgroups_short V 1.1.0 short16 is allowed for these
builtins.

Signed-off-by: Sidorov, Dmitry <[email protected]>

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@6895a2eb5d053d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@premanandrao premanandrao premanandrao left review comments

@elizabethandrews elizabethandrews Awaiting requested review from elizabethandrews

@Fznamznon Fznamznon Awaiting requested review from Fznamznon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asi-sc @Fznamznon @premanandrao