Skip to content

[SYCL][ESIMD] Enable type rewriting in spirv writer adaptor #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SYCL][ESIMD] Enable type rewriting in spirv writer adaptor #2718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion clang/lib/CodeGen/BackendUtil.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,7 +942,8 @@ void EmitAssemblyHelper::EmitAssembly(BackendAction Action,
PerModulePasses.add(createDeadArgEliminationSYCLPass());

if (LangOpts.SYCLIsDevice && LangOpts.SYCLExplicitSIMD)
PerModulePasses.add(createGenXSPIRVWriterAdaptorPass());
PerModulePasses.add(
createGenXSPIRVWriterAdaptorPass(/*RewriteTypes=*/true));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not entirely sure what this change does. Can you provide some details in the commit description?
Please add an appropriate test as well.

Copy link
Contributor

@Fznamznon Fznamznon Nov 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it would be great to have some context here. Although I'm not sure if front-end test is required. I think this thing enables some functionality of the GenXSPIRVWriterAdaptorPass which is likely already tested by LIT suite for this particular pass.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll add some details in the next iteration of this change. We've realized that an additional change in vc-intrinsics (library where GenXSPIRVAdaptorPass comes from) is required. So, I mark the pull request as a draft for now.


switch (Action) {
case Backend_EmitNothing:
Expand Down