[SYCL][FPGA] Remove support for intel::fpga_pipeline attribute

[smanna12]

Support for new FPGA attribute called [[intel::fpga_pipeline(N)]]
added on #6254 is no longer needed.

This patch removes the support from frontend.

Signed-off-by: Soumi Manna [email protected]

[smanna12]

The failure is unrelated to my patch:

---

Unresolved Tests (1):
SYCL :: Assert/assert_in_simultaneous_kernels.cpp
https://github.com/intel/llvm/runs/7642204197?check_suite_focus=true

[bader]

The failure is unrelated to my patch:

Unresolved Tests (1): SYCL :: Assert/assert_in_simultaneous_kernels.cpp https://github.com/intel/llvm/runs/7642204197?check_suite_focus=true

Most likely it's caused by ade1870. @npmiller, could you take a look, please?

[npmiller]

Yeah it's likely related, I'll investigate further, in the meantime to unblock the CI I filed a PR to revert the test to unsupported and filed a ticket to track it:

• [SYCL][HIP] Disable flaky HIP test llvm-test-suite#1126
• Investigate flaky assert tests for HIP #6520

Sorry about that!

[elizabethandrews]

I compared this PR to 6254 and I see some code you added in SemaDeclAttr.cpp to deprecate [[intel::disable_loop_pipelining]] attribute spelling in favor of [[intel::fpga_pipeline]]. Shouldn't we remove that code as well. Also, now that [[intel::fpga_pipeline]] s removed how are we handling [[intel::disable_loop_pipelining]]?

[smanna12]

I compared this PR to 6254 and I see some code you added in SemaDeclAttr.cpp to deprecate [[intel::disable_loop_pipelining]] attribute spelling in favor of [[intel::fpga_pipeline]]. Shouldn't we remove that code as well. Also, now that [[intel::fpga_pipeline]] s removed how are we handling [[intel::disable_loop_pipelining]]?

Thanks @elizabethandrews for reviews. It has been handled as per #6404

[elizabethandrews]

I compared this PR to 6254 and I see some code you added in SemaDeclAttr.cpp to deprecate [[intel::disable_loop_pipelining]] attribute spelling in favor of [[intel::fpga_pipeline]]. Shouldn't we remove that code as well. Also, now that [[intel::fpga_pipeline]] s removed how are we handling [[intel::disable_loop_pipelining]]?

Thanks @elizabethandrews for reviews. It has been handled as per #6404

Thank you for clarifying

[smanna12]

ping @mendell27

[smanna12]

Thank you everyone for the review.