Skip to content

import local @angular-devkit/schematics #3023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rdlabo
Copy link
Contributor

@rdlabo rdlabo commented Mar 23, 2018

Default import @angular-devkit/schematics use global one.

ionic-team/starters@155d3f6 commit is locally. so change import directory.

#3019 (comment)

Default import @angular-devkit/schematics use global one.

ionic-team/starters@155d3f6 commit is locally. so change import directory.
@rdlabo rdlabo requested a review from imhoffd as a code owner March 23, 2018 03:00
@imhoffd
Copy link
Contributor

imhoffd commented Mar 23, 2018

Thanks for taking a look and finding the issue, @rdlabo!!

Would you mind changing it slightly to work like this example:

Doing this will make sure it 1) uses node modules resolution algorithm and 2) work for cases when the dev is in a subfolder of the project.

Does that sound reasonable? 😄

@rdlabo
Copy link
Contributor Author

rdlabo commented Mar 23, 2018

thanks for review and reply.

I made new pull request #3024 and this commit is close.

@rdlabo rdlabo closed this Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants