import local @angular-devkit/schematics #3024
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, with my comment I was trying to give you an example of a function that has one parameter, the project directory (local), and then uses that to configure
|
imhoffd
suggested changes
Mar 23, 2018
| @@ -0,0 +1,8 @@ | |||
| import { compileNodeModulesPaths, resolve } from '@ionic/cli-framework/utils/npm'; | |||
|
|
|||
| export async function importAppScripts(projectDir: string): Promise<any> { | |||
There was a problem hiding this comment.
Define two functions, one for importing @angular-devkit/schematics and one for @angular-devkit/schematics/tools.
| @@ -208,8 +209,8 @@ ${chalk.cyan('[1]')}: ${chalk.bold('https://ionicframework.com/docs/cli/projects | |||
| private async getSchematics(): Promise<Schematic[]> { | |||
| if (!this.schematics) { | |||
| try { | |||
| const { SchematicEngine } = await import('@angular-devkit/schematics'); | |||
| const { NodeModulesEngineHost } = await import('@angular-devkit/schematics/tools'); | |||
| const { SchematicEngine } = await importAppScripts('@angular-devkit/schematics'); | |||
There was a problem hiding this comment.
You'll need to pass in this.project.directory to the two functions, not the module name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is update by 8a83c6b .
use Function importAppScripts.