Skip to content

issue(item-reorder): Should be able to specify a side #11637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dylanvdmerwe opened this issue May 12, 2017 · 8 comments
Closed

issue(item-reorder): Should be able to specify a side #11637

dylanvdmerwe opened this issue May 12, 2017 · 8 comments

Comments

@dylanvdmerwe
Copy link
Contributor

Ionic version: (check one with "x")
[x] 2.x
[x] 3.x

I'm submitting a ... (check one with "x")
[x] feature request

Note that I don't think this is a feature request, because hard-coded logic like this shouldn't be there.

Current behavior:
You should be able to specify the side that you want an ion-reorder to appear. Currently it is hard-coded to be on the RHS. Even moving the reorder icon does not work as the logic is hard coded: https://github.com/driftyco/ionic/blob/master/src/components/item/item-reorder-gesture.ts#L137

Expected behavior:
Specify a side that the ion-reorder icon should be, and have the logic work when dragging an icon on the specified side.

See here for an unfinished PR: #9250

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

global packages:

    @ionic/cli-utils : 1.0.0
    Cordova CLI      : 7.0.0
    Ionic CLI        : 3.0.0

local packages:

    @ionic/app-scripts              : 1.3.7
    @ionic/cli-plugin-cordova       : 1.0.0
    @ionic/cli-plugin-ionic-angular : 1.0.0
    Ionic Framework                 : ionic-angular 3.1.1

System:

    Node       : v6.9.5
    OS         : macOS Sierra
    Xcode      : Xcode 8.3.2 Build version 8E2002
    ios-deploy : 1.9.0
    ios-sim    : 5.0.10
@AmitMY
Copy link
Contributor

AmitMY commented May 12, 2017

Is this specifically for RTL, or generally needed?

@dylanvdmerwe
Copy link
Contributor Author

Would probably be useful for RTL, but is a general thing.

@manucorporat
Copy link
Contributor

manucorporat commented May 12, 2017

Yeah... so reorder already works in RTL, we just need to add some little logic + css
https://github.com/driftyco/ionic/blob/master/src/components/item/item-reorder-gesture.ts#L137

so the reorder burger shows in the left side in LTR apps and in the right side in RTL

@AmitMY
Copy link
Contributor

AmitMY commented May 12, 2017

@dylanvdmerwe Is this what you need? #11639

@dylanvdmerwe
Copy link
Contributor Author

Yes that looks exactly right! Epic @AmitMY

@jgw96
Copy link
Contributor

jgw96 commented Jun 5, 2017

Hello everyone! Thanks for the feature request. I'm going to move this issue over to our internal list of feature requests for evaluation. We are continually prioritizing all requests that we receive with outstanding issues. We are extremely grateful for your feedback, but it may not always be our next priority. I'll copy the issue back to this repository when we have begun implementation. Thanks!

@jgw96 jgw96 closed this as completed Jun 5, 2017
@jgw96
Copy link
Contributor

jgw96 commented Jun 5, 2017

This issue was moved to ionic-team/ionic-feature-requests#243

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 2, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants