-
Notifications
You must be signed in to change notification settings - Fork 13.5k
issue(item-reorder): Should be able to specify a side #11637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is this specifically for RTL, or generally needed? |
Would probably be useful for RTL, but is a general thing. |
Yeah... so reorder already works in RTL, we just need to add some little logic + css so the reorder burger shows in the left side in LTR apps and in the right side in RTL |
@dylanvdmerwe Is this what you need? #11639 |
Yes that looks exactly right! Epic @AmitMY |
Hello everyone! Thanks for the feature request. I'm going to move this issue over to our internal list of feature requests for evaluation. We are continually prioritizing all requests that we receive with outstanding issues. We are extremely grateful for your feedback, but it may not always be our next priority. I'll copy the issue back to this repository when we have begun implementation. Thanks! |
This issue was moved to ionic-team/ionic-feature-requests#243 |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Ionic version: (check one with "x")
[x] 2.x
[x] 3.x
I'm submitting a ... (check one with "x")
[x] feature request
Note that I don't think this is a feature request, because hard-coded logic like this shouldn't be there.
Current behavior:
You should be able to specify the side that you want an
ion-reorder
to appear. Currently it is hard-coded to be on the RHS. Even moving the reorder icon does not work as the logic is hard coded: https://github.com/driftyco/ionic/blob/master/src/components/item/item-reorder-gesture.ts#L137Expected behavior:
Specify a side that the
ion-reorder
icon should be, and have the logic work when dragging an icon on the specified side.See here for an unfinished PR: #9250
Ionic info: (run
ionic info
from a terminal/cmd prompt and paste output below):The text was updated successfully, but these errors were encountered: