Skip to content

perf(reorder): debouncing events + new algorithm #9250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

manucorporat
Copy link
Contributor

@manucorporat manucorporat commented Nov 20, 2016

WIP

DO NOT MERGE

BEFORE:
screen shot 2016-11-20 at 11 58 31

AFTER:
screen shot 2016-11-20 at 13 07 16

Ionic Version: 2.x

fixes #7522

@manucorporat manucorporat added this to the 2.0.0-rc.4 milestone Nov 20, 2016
@jgw96 jgw96 removed this from the 2.0.0-rc.4 milestone Dec 2, 2016
@manucorporat manucorporat added this to the 2.0.0-rc.5 milestone Dec 9, 2016
@jgw96 jgw96 removed this from the 2.0.0-rc.5 milestone Dec 16, 2016
let children = this._element.children;
console.log('from', fromIndex, 'to', toIndex);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.log should be removed.

@brandyscarney
Copy link
Member

Can we get the merge conflicts on this fixed and is it ready to merge or can it be?

@manucorporat
Copy link
Contributor Author

This is going to be parte of V4

@FedericoAlvarez
Copy link

Are those changes currently merged? Because I'm having the Item Reorder reports wrong indexes when dropped on original position issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder ion-items sometimes blocked together
5 participants