Skip to content

(reorder fixes:) https://github.com/driftyco/ionic/issues/7522 #8818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

estyles
Copy link

@estyles estyles commented Oct 20, 2016

Short description of what this resolves:

#7522
-items getting 'stuck together'
-items not getting the right .toIndex when dropped back in their original positions

Changes proposed in this pull request:

  • sets right indexes
  • needs temporary bottom item to get right index when dragged to bottom of list (probably there is a way around this, but I couldn't figure out a better way

Ionic Version: 2.x

@jgw96
Copy link
Contributor

jgw96 commented Jan 31, 2017

Hello! Thanks for opening this PR! Would you be able to fix the conflicts here?

@jgw96 jgw96 added the needs: reply the issue needs a response from the user label Jan 31, 2017
@brandyscarney
Copy link
Member

Thanks for the PR! I'm going to close this since it seems Manu has been working on this on a different PR: #9250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: reply the issue needs a response from the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants