Reorder ion-items sometimes blocked together

[danbucholtz]

Sometimes, when I am trying to perform a re-order, my ion-items get "grouped" together and I cannot drop at a certain index. See the video here for the recreation. I am able to recreate this using the basic e2e test for re-order.

Thanks,
Dan

[danbucholtz]

Forgot the link, here you go:

https://drive.google.com/a/drifthack.com/file/d/0B7Xofj71-_MbbkV3OGZKSTVSanc/view?usp=sharing

[manucorporat]

@danbucholtz I am aware of this issue, thanks for creating an issue.
I am still not sure how to fix it though

[estyles]

in case these two issues are related, this fixes the one I opened.
estyles@4c8bbdf

[estyles]

Ok looked into it again, the above fix didn't actually fix the problem just some syptoms.

I managed to fix both the 'blocked together' and the 'wrong index' bug now.
But this fix does require a temporary div to be inserted at the bottom of the list while reordering, to allow reordering to the last index, which is not ideal.
There is probably some way to do without, but I'm quite sure reordering works correctly now.
I can create a pull request if needed, but I didn't write any tests, and my code probably should use renderer for the dom updates.

for changes see: master...estyles:master

[manucorporat]

Please create the PR! I will look into it! it might not be the best solution, but you are getting close. Please submit it!!

[manucorporat]

@estyles I am working in a new algorithm for reorder list that fixes this issue and improves the performance

[zakton5]

@manucorporat Can we go ahead and pull this in if it works? If not, I can make my own PR with a fix that solved both problems.

[ionitron-bot]

Thanks for the issue! This issue is being closed due to inactivity. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

Thank you for using Ionic!