chore: sync with main #28238
Merged
chore: sync with main #28238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue number: Resolves #26391 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When updating the `value` programmatically on an `ion-datetime` after it has already been created: - With grid style: The selected date visually updates, but the calendar does not scroll to the newly selected month. - With wheel style: The selected date does not visually update, i.e. the wheels do not move to show the newly selected date. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Grid style datetimes now scroll to the selected date using the same animation as when clicking the next/prev month buttons. - This animation mirrors the behavior in both MUI and native iOS. See the [design doc](https://github.com/ionic-team/ionic-framework-design-documents/blob/main/projects/ionic-framework/components/datetime/0003-datetime-async-value.md) for more information and screen recordings. - The animation will not occur if the month/year did not change, or when the datetime is hidden. - Wheel style datetimes now visually update to the selected date. No animation occurs, also mirroring native. - The `parseDate` util has also had its type signatures updated to account for returning `undefined` when the date string is improperly formatted. This was missed when the util was refactored to support multiple date selection. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> - Docs PR: ionic-team/ionic-docs#3053 - While this can technically be considered a bug fix, we are merging it into a feature branch for safety; it's a fairly significant change to how datetime behaves, and may interfere with custom logic when updating a datetime's value async. - Jumping to the newly selected value is handled by replacing everything [here](https://github.com/ionic-team/ionic-framework/pull/27806/files#diff-4a407530c60e3cf72bcc11acdd21c4803a94bf47ea81b99e757db1c93d2735b8L364-L407) with `processValue()`. This covers both wheel and grid datetimes. - `activePartsClone` as a whole was also removed. It was added in #24244 to enable changing `activeParts` without triggering a rerender (and thus jumping to the new value) but since we now want to do that jump, the clone is no longer needed. - The animation code might be tricky to follow, so I recorded going through it: https://github.com/ionic-team/ionic-framework/assets/90629384/1afa5762-f493-441a-b662-f0429f2d86a7
chore: sync with main
chore: sync with main
#28075) Co-authored-by: Liam DeBeasi <[email protected]> Co-authored-by: ionitron <[email protected]>
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 4.1.0 to 4.2.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>🌲 4.2.0 (2023-09-05)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> resolve implicit enum types (<a href="https://redirect.github.com/ionic-team/stencil/issues/4739">#4739</a>) (<a href="https://github.com/ionic-team/stencil/commit/f5a3bd8739a4b9eab3b8b9b1f9c808c47b2aa4fc">f5a3bd8</a>)</li> <li><strong>runtime:</strong> patch methods for scoped slot <code>append</code>, <code>prepend</code>, and <code>insertAdjacent</code> (<a href="https://redirect.github.com/ionic-team/stencil/issues/4719">#4719</a>) (<a href="https://github.com/ionic-team/stencil/commit/1d98462135a196b9d9037dd46f0e7fe55d108496">1d98462</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>typescript:</strong> upgrade to TypeScript 5.1 (<a href="https://redirect.github.com/ionic-team/stencil/pull/4718">#4718</a>) (<a href="https://github.com/ionic-team/stencil/commit/49df0e7b9bc1862d690e3239404243de1c838d6d">49df0e7</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h1>🎺 <a href="https://github.com/ionic-team/stencil/compare/v4.2.0-0...v4.2.0">4.2.0</a> (2023-09-05)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> resolve implicit enum types (<a href="https://redirect.github.com/ionic-team/stencil/issues/4739">#4739</a>) (<a href="https://github.com/ionic-team/stencil/commit/f5a3bd8739a4b9eab3b8b9b1f9c808c47b2aa4fc">f5a3bd8</a>)</li> <li><strong>runtime:</strong> patch methods for scoped slot <code>append</code>, <code>prepend</code>, and <code>insertAdjacent</code> (<a href="https://redirect.github.com/ionic-team/stencil/issues/4719">#4719</a>) (<a href="https://github.com/ionic-team/stencil/commit/1d98462135a196b9d9037dd46f0e7fe55d108496">1d98462</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>typescript:</strong> upgrade to TypeScript 5.1 (<a href="https://redirect.github.com/ionic-team/stencil/pull/4718">#4718</a>) (<a href="https://github.com/ionic-team/stencil/commit/49df0e7b9bc1862d690e3239404243de1c838d6d">49df0e7</a>)</li> </ul> <h1>🐸 <a href="https://github.com/ionic-team/stencil/compare/v4.1.0...v4.2.0-0">4.2.0-0</a> (2023-09-05)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> resolve implicit enum types (<a href="https://redirect.github.com/ionic-team/stencil/issues/4739">#4739</a>) (<a href="https://github.com/ionic-team/stencil/commit/f5a3bd8739a4b9eab3b8b9b1f9c808c47b2aa4fc">f5a3bd8</a>)</li> <li><strong>runtime:</strong> patch methods for scoped slot <code>append</code>, <code>prepend</code>, and <code>insertAdjacent</code> (<a href="https://redirect.github.com/ionic-team/stencil/issues/4719">#4719</a>) (<a href="https://github.com/ionic-team/stencil/commit/1d98462135a196b9d9037dd46f0e7fe55d108496">1d98462</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>typescript:</strong> upgrade to TypeScript 5.1 (<a href="https://redirect.github.com/ionic-team/stencil/pull/4718">#4718</a>) (<a href="https://github.com/ionic-team/stencil/commit/49df0e7b9bc1862d690e3239404243de1c838d6d">49df0e7</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/44e10d2cdfd5f7bb4c81cb24bb5e7e54a75680d0"><code>44e10d2</code></a> Release v4.2.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4758">#4758</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/817701c58f1d486ab8f9fa0cd5af809ecb75b18c"><code>817701c</code></a> Release v4.2.0-0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4757">#4757</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/1d98462135a196b9d9037dd46f0e7fe55d108496"><code>1d98462</code></a> fix(runtime): patch methods for scoped slot <code>append</code>, <code>prepend</code>, and `insertA...</li> <li><a href="https://github.com/ionic-team/stencil/commit/1567f8693a0dc10060957836ae7891975e191913"><code>1567f86</code></a> chore(snc): eliminate TS2774 errors (<a href="https://redirect.github.com/ionic-team/stencil/issues/4750">#4750</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/efa93dd450df276d421d230854b64a4992dbfc24"><code>efa93dd</code></a> chore(snc): fix a single SNC error in query-nonce-meta-tag-content.spec.ts (#...</li> <li><a href="https://github.com/ionic-team/stencil/commit/ec0778d8e4e477e047ab7400a7155c4c43d7899e"><code>ec0778d</code></a> chore(deps): update dependency postcss to v8.4.29 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4754">#4754</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/29fa192eddc7f391291f8f7441d6d6a6f572c838"><code>29fa192</code></a> chore(snc): drop snc count for serialize-css (<a href="https://redirect.github.com/ionic-team/stencil/issues/4730">#4730</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/94009485a04b18d6fa9da92b8fe5c70026719190"><code>9400948</code></a> chore(deps): update dependency <code>@rollup/pluginutils</code> to v5.0.4 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4742">#4742</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/0f2db7dfa1bcb20775e01c0777eb96b91433cac6"><code>0f2db7d</code></a> chore(deps): update dependency <code>@types/node</code> to v20.5.6 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4731">#4731</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/1482bc8b0a632bfc9c7b45bb1a00c02bd10126c4"><code>1482bc8</code></a> chore(deps): update dependency <code>@types/listr</code> to v0.14.5 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4751">#4751</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v4.1.0...v4.2.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Issue number: resolves #25340 --------- - Exposes the following parts for a calendar day: `calendar-day`, `today`, and `active` - Combines the `calendar-day-highlight` element with the `calendar-day` element so developers don't have to know to style two different elements & we don't have to expose them as separate parts - Improves height parity of the calendar day across browsers - Updates the `custom` e2e test to include an example of styling days using the newly exposed CSS parts - Adds tests for the focus states of the calendar day
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When the "Update Reference Screenshot" job is run but no new screenshots are generated, the following error is logged: ``` nothing added to commit but untracked files present (use "git add" to track) Error: Process completed with exit code 1. ``` This is happening because there are no files to commit when running `git commit`. Brandy noted that this was confusing since it doesn't actually tell you why there are no files to commit. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - If there are no diffs to commit then the update screenshot script will log a message saying that no screenshot diffs were generated. Example: ```⚠️ Error: No new screenshots generated⚠️ This means that there were zero visual diffs when running screenshot tests. Make sure you have pushed any code changes that would result in visual diffs. ``` https://github.com/ionic-team/ionic-framework/actions/runs/6099399582/job/16552017414 ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The `--ion-safe-area-left` and `--ion-safe-area-right` variables in `ion-menu` are being set as if they use the app's direction. It's been determined that safe area is not logical and uses the device's direction. The current implementation is adding padding in the wrong sides for `ion-toolbar` and `ion-content` within a `ion-menu`. Additionally, `ion-menu` does not use the entire screen so the safe area only needs to be applied to the side that is touching the device screen. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Set the `--ion-safe-area-left` and `--ion-safe-area-right` variables to the correct values based on the device's direction. - Padding is only added to the side that is not in the safe area. - `ion-toolbar` is adding `--ion-safe-area-left` and `--ion-safe-area-right` based on the device's direction. - `ion-toolbar` can now inherit the correct values from `--ion-safe-area-left` and `--ion-safe-area-right`. - `ion-content` can now inherit the correct values from `--ion-safe-area-left` and `--ion-safe-area-right`. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: 7.3.4-dev.11694015543.18bc484f
Issue number: resolves #28137 --------- Changes according to [this comment](#28137 (comment)) ## Does this introduce a breaking change? - [ ] Yes - [x] No @liamdebeasi Sorry for replacing the previous PR. I only copied the main branch to my fork so I couldn't rebase properly. I am unfortunately not extremely familiar with Github. --------- Co-authored-by: Philipp Heuer <[email protected]> Co-authored-by: Liam DeBeasi <[email protected]>
…8.2 in /core (#28149) Bumps [@stencil/angular-output-target](https://github.com/ionic-team/stencil-ds-output-targets) from 0.7.1 to 0.8.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil-ds-output-targets/releases"><code>@stencil/angular-output-target</code>'s releases</a>.</em></p> <blockquote> <h2><code>@stencil/angular-output-target</code><a href="https://github.com/0"><code>@0</code></a>.8.2</h2> <h2>What's Changed</h2> <ul> <li>fix(angular-output-target): rewrite nested generics for custom events by <a href="https://github.com/sean-perkins"><code>@sean-perkins</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/pull/371">ionic-team/stencil-ds-output-targets#371</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/ionic-team/stencil-ds-output-targets/compare/@stencil/[email protected]...@stencil/[email protected]">https://github.com/ionic-team/stencil-ds-output-targets/compare/<code>@stencil/angular-output-target</code><code>@0.8.1...</code><code>@stencil/angular-output-target</code><code>@0.8.2</code></a></p> <h2><code>@stencil/angular-output-target</code><a href="https://github.com/0"><code>@0</code></a>.8.1</h2> <h2>What's Changed</h2> <ul> <li>fix(angular-output-target): multiple targets do not overwrite each other by <a href="https://github.com/sean-perkins"><code>@sean-perkins</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/pull/376">ionic-team/stencil-ds-output-targets#376</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/ionic-team/stencil-ds-output-targets/compare/@stencil/[email protected]...@stencil/[email protected]">https://github.com/ionic-team/stencil-ds-output-targets/compare/<code>@stencil/angular-output-target</code><code>@0.8.0...</code><code>@stencil/angular-output-target</code><code>@0.8.1</code></a></p> <h2><code>@stencil/angular-output-target</code><a href="https://github.com/0"><code>@0</code></a>.8.0</h2> <h2>What's Changed</h2> <ul> <li>feat(angular-output-target): generate standalone components by <a href="https://github.com/sean-perkins"><code>@sean-perkins</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/pull/367">ionic-team/stencil-ds-output-targets#367</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/ionic-team/stencil-ds-output-targets/compare/@stencil/[email protected]...@stencil/[email protected]">https://github.com/ionic-team/stencil-ds-output-targets/compare/<code>@stencil/angular-output-target</code><code>@0.7.1...</code><code>@stencil/angular-output-target</code><code>@0.8.0</code></a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/afe862ef6033408413cab16224c195ec5acc0e0c"><code>afe862e</code></a> chore(angular-output-target): manually bumping the package version (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/387">#387</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/126dc39e5b7427a9efc2a57442e02b8ca43675bc"><code>126dc39</code></a> fix(angular-output-target): rewrite nested generics for custom events (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/372">#372</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/d37ebd7955ccdfd679f16a555c354fd0d02207cc"><code>d37ebd7</code></a> chore(deps): update actions/checkout action to v4 (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/386">#386</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/7dabd06b2df96fc76718f69e0550ae481381f15b"><code>7dabd06</code></a> chore(deps): update actions/checkout action to v3.6.0 (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/384">#384</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/0b022bc2efccc544c226e464f51c8e21c4f58654"><code>0b022bc</code></a> chore(deps): update actions/setup-node action to v3.8.1 (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/380">#380</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/c23bbfbbca73046a7f809395ce6db632a22b94a3"><code>c23bbfb</code></a> chore(angular-output-target): manually bumping the package version (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/377">#377</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/3c6a3252c762618799dac60d78a3b6cafe983604"><code>3c6a325</code></a> fix(angular-output-target): multiple targets do not overwrite each other (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/376">#376</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/2de5d649c3be2620d8eaaa15aafa2f76e41753fa"><code>2de5d64</code></a> chore(deps): update actions/setup-node action to v3.8.0 (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/375">#375</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/ae79bf76516daa33da1fc3052a78d8b3b678b8c2"><code>ae79bf7</code></a> chore(angular-output-target): manually bumping the package version (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/373">#373</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/01c9c098193c7c020be060851e5cc970d2702e82"><code>01c9c09</code></a> chore: publish-npm workflow uses local lerna version (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/371">#371</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil-ds-output-targets/compare/@stencil/[email protected]...@stencil/[email protected]">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
chore: sync with main
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 4.2.0 to 4.2.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>😀 v4.2.1 (2023-09-11)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> add heritage clauses earlier in native transform (<a href="https://redirect.github.com/ionic-team/stencil/issues/4769">#4769</a>) (<a href="https://github.com/ionic-team/stencil/commit/9a92ad12f628a5c2eae3048bda983fed2bc140b5">9a92ad1</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h2>🌝 <a href="https://github.com/ionic-team/stencil/compare/v4.2.0...v4.2.1">4.2.1</a> (2023-09-11)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> add heritage clauses earlier in native transform (<a href="https://redirect.github.com/ionic-team/stencil/issues/4769">#4769</a>) (<a href="https://github.com/ionic-team/stencil/commit/9a92ad12f628a5c2eae3048bda983fed2bc140b5">9a92ad1</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/29fa4b38c4ae9a5e2d1efc19a0ed50c6df9a14ca"><code>29fa4b3</code></a> v4.2.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4780">#4780</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/9a92ad12f628a5c2eae3048bda983fed2bc140b5"><code>9a92ad1</code></a> fix(compiler): add heritage clauses earlier in native transform (<a href="https://redirect.github.com/ionic-team/stencil/issues/4769">#4769</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/9ee02c518f7b5cb06001016c7cfcb62ba591d68f"><code>9ee02c5</code></a> chore(deps): update typescript-eslint to v6.6.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4777">#4777</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/9229a6203320344a5aac389fd0b0e8e7f9d5861a"><code>9229a62</code></a> chore(deps): update actions/upload-artifact action to v3.1.3 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4773">#4773</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/25fcaa9e8e1a494fd05c5c01b20c5525669d5114"><code>25fcaa9</code></a> chore(deps): update dependency terser to v5.19.4 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4774">#4774</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/81a1e2c67c849db792eca9f9ad6fae2d1e6e5ef5"><code>81a1e2c</code></a> chore(deps): update node.js to v20.6.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4776">#4776</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/f4724f6341cd209f28b0239c89df12136f15030a"><code>f4724f6</code></a> chore(deps): update actions/checkout action to v4 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4778">#4778</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/a1ab21bdebdbbfebc31bdf8a6dd8eac5ed560be7"><code>a1ab21b</code></a> chore(deps): update dependency npm to v10 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4766">#4766</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/dd1fe1d0b01723ef4d88f5eb24d34eae0cf7ac1c"><code>dd1fe1d</code></a> chore(deps): update node.js to v20.5.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4607">#4607</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/4d8ff009156b33d93daa3decad73b48c186fe7b9"><code>4d8ff00</code></a> refactor(compiler): use updateConstructor in lazy transform (<a href="https://redirect.github.com/ionic-team/stencil/issues/4768">#4768</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v4.2.0...v4.2.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Release 7.3.4
chore: sync with main
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> We checked `git diff` to see if new screenshots were generated. If no new screenshots were generated then we print a user-friendly message informing the dev what happened. However, `git diff` does not account for untracked changes (i.e. new screenshots). As a result, this prevented new screenshots from being committed. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - To fix this we use the `-N` flag which is short for `--intent-to-add`. This adds an entry with no content which causes the new screenshots to show up when running `git diff`. We later add the contents of the image. Example test run of this working: https://github.com/ionic-team/ionic-framework/actions/runs/6174263712/job/16759260534 ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
chore: sync with main
Release 7.4
Release 7.4.1
…27821) Issue number: Resolves #27798 --------- ## What is the current behavior React IonNav component's views are missing keys, leading to unnecessary duplicate mounting of components. ## What is the new behavior? - Adds key to views of React IonNav component. ## Does this introduce a breaking change? - [ ] Yes - [x] No --------- Co-authored-by: Sean Perkins <[email protected]>
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Some of the tests for `item-sliding` were being skipped due to flakiness. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Updated the tests to use the stable function, `dragElementBy` to handle gestures, removing the gesture flakiness. - Separated the basic test to lessen the gesture complexity else it becomes flaky since it can't handle opening and closing and opening in the same test. - Tests are now checking all modes and all directions. - Updated a utils function with a warning regarding an open issue with RTL. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> N/A --------- Co-authored-by: ionitron <[email protected]> Co-authored-by: Brandy Carney <[email protected]>
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> CI is failing for Cypress apps due to cypress-io/cypress#27804 (comment). ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - All Cypress test apps have been updated to Cypress 13.2.0 which is not affected by this issue. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The `fill` prop on `ion-item` is currently deprecated (see warning [here](https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/item/item.tsx#L248-L253)) but the docs have not been updated to reflect this. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> `@deprecated` flag added to the `fill` prop. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
…28215) Bumps [@capacitor/core](https://github.com/ionic-team/capacitor) from 5.4.0 to 5.4.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/capacitor/releases"><code>@capacitor/core</code>'s releases</a>.</em></p> <blockquote> <h2>5.4.1</h2> <h2><a href="https://github.com/ionic-team/capacitor/compare/5.4.0...5.4.1">5.4.1</a> (2023-09-21)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>android:</strong> handle webview version for developer builds (<a href="https://redirect.github.com/ionic-team/capacitor/issues/6911">#6911</a>) (<a href="https://github.com/ionic-team/capacitor/commit/b5b0398a7fe117a824f97125f5feabe81073daf3">b5b0398</a>)</li> <li><strong>android:</strong> Use Logger class instead of Log in CapacitorCookieManager (<a href="https://redirect.github.com/ionic-team/capacitor/issues/6925">#6925</a>) (<a href="https://github.com/ionic-team/capacitor/commit/b6901e01e05cd22a71841d2f5821fbe2a6939ead">b6901e0</a>)</li> <li><strong>cli:</strong> force latest native-run version for iOS 17 support (<a href="https://redirect.github.com/ionic-team/capacitor/issues/6928">#6928</a>) (<a href="https://github.com/ionic-team/capacitor/commit/f9be9f5791e6f0881be2c73bb8fbe7a8c1b10848">f9be9f5</a>)</li> <li><strong>cookies:</strong> retrieve cookies when using a custom android scheme (<a href="https://github.com/ionic-team/capacitor/commit/6b5ddad8b36e33ef4171f6da5cc311ed3f634ac6">6b5ddad</a>)</li> <li><strong>http:</strong> parse readablestream data on fetch request objects (<a href="https://github.com/ionic-team/capacitor/commit/3fe06426bd20713e2322780b70bc5d97ad371fae">3fe0642</a>)</li> <li><strong>http:</strong> return xhr response headers case insensitive (<a href="https://github.com/ionic-team/capacitor/commit/687b6b1780506c17fb73ed1d9cbf50c1d1e40ef1">687b6b1</a>)</li> <li><strong>ios:</strong> Add workaround for CocoaPods problem on Xcode 15 (<a href="https://redirect.github.com/ionic-team/capacitor/issues/6921">#6921</a>) (<a href="https://github.com/ionic-team/capacitor/commit/1ffa2441fc8a04e4bf1712d0afb868a83e7f1951">1ffa244</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/capacitor/blob/5.4.1/CHANGELOG.md"><code>@capacitor/core</code>'s changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/ionic-team/capacitor/compare/5.4.0...5.4.1">5.4.1</a> (2023-09-21)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>android:</strong> handle webview version for developer builds (<a href="https://redirect.github.com/ionic-team/capacitor/issues/6911">#6911</a>) (<a href="https://github.com/ionic-team/capacitor/commit/b5b0398a7fe117a824f97125f5feabe81073daf3">b5b0398</a>)</li> <li><strong>android:</strong> Use Logger class instead of Log in CapacitorCookieManager (<a href="https://redirect.github.com/ionic-team/capacitor/issues/6925">#6925</a>) (<a href="https://github.com/ionic-team/capacitor/commit/b6901e01e05cd22a71841d2f5821fbe2a6939ead">b6901e0</a>)</li> <li><strong>cli:</strong> force latest native-run version for iOS 17 support (<a href="https://redirect.github.com/ionic-team/capacitor/issues/6928">#6928</a>) (<a href="https://github.com/ionic-team/capacitor/commit/f9be9f5791e6f0881be2c73bb8fbe7a8c1b10848">f9be9f5</a>)</li> <li><strong>cookies:</strong> retrieve cookies when using a custom android scheme (<a href="https://github.com/ionic-team/capacitor/commit/6b5ddad8b36e33ef4171f6da5cc311ed3f634ac6">6b5ddad</a>)</li> <li><strong>http:</strong> parse readablestream data on fetch request objects (<a href="https://github.com/ionic-team/capacitor/commit/3fe06426bd20713e2322780b70bc5d97ad371fae">3fe0642</a>)</li> <li><strong>http:</strong> return xhr response headers case insensitive (<a href="https://github.com/ionic-team/capacitor/commit/687b6b1780506c17fb73ed1d9cbf50c1d1e40ef1">687b6b1</a>)</li> <li><strong>ios:</strong> Add workaround for CocoaPods problem on Xcode 15 (<a href="https://redirect.github.com/ionic-team/capacitor/issues/6921">#6921</a>) (<a href="https://github.com/ionic-team/capacitor/commit/1ffa2441fc8a04e4bf1712d0afb868a83e7f1951">1ffa244</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/capacitor/commit/3934cf64038cf1983e8ca3e6dba601703e510e13"><code>3934cf6</code></a> Release 5.4.1</li> <li><a href="https://github.com/ionic-team/capacitor/commit/3fe06426bd20713e2322780b70bc5d97ad371fae"><code>3fe0642</code></a> fix(http): parse readablestream data on fetch request objects</li> <li><a href="https://github.com/ionic-team/capacitor/commit/687b6b1780506c17fb73ed1d9cbf50c1d1e40ef1"><code>687b6b1</code></a> fix(http): return xhr response headers case insensitive</li> <li><a href="https://github.com/ionic-team/capacitor/commit/f9be9f5791e6f0881be2c73bb8fbe7a8c1b10848"><code>f9be9f5</code></a> fix(cli): force latest native-run version for iOS 17 support (<a href="https://redirect.github.com/ionic-team/capacitor/issues/6928">#6928</a>)</li> <li><a href="https://github.com/ionic-team/capacitor/commit/6b5ddad8b36e33ef4171f6da5cc311ed3f634ac6"><code>6b5ddad</code></a> fix(cookies): retrieve cookies when using a custom android scheme</li> <li><a href="https://github.com/ionic-team/capacitor/commit/1ffa2441fc8a04e4bf1712d0afb868a83e7f1951"><code>1ffa244</code></a> fix(ios): Add workaround for CocoaPods problem on Xcode 15 (<a href="https://redirect.github.com/ionic-team/capacitor/issues/6921">#6921</a>)</li> <li><a href="https://github.com/ionic-team/capacitor/commit/b6901e01e05cd22a71841d2f5821fbe2a6939ead"><code>b6901e0</code></a> fix(android): Use Logger class instead of Log in CapacitorCookieManager (<a href="https://redirect.github.com/ionic-team/capacitor/issues/6925">#6925</a>)</li> <li><a href="https://github.com/ionic-team/capacitor/commit/b5b0398a7fe117a824f97125f5feabe81073daf3"><code>b5b0398</code></a> fix(android): handle webview version for developer builds (<a href="https://redirect.github.com/ionic-team/capacitor/issues/6911">#6911</a>)</li> <li>See full diff in <a href="https://github.com/ionic-team/capacitor/compare/5.4.0...5.4.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#28214) Bumps [@playwright/test](https://github.com/Microsoft/playwright) from 1.38.0 to 1.38.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Microsoft/playwright/releases"><code>@playwright/test</code>'s releases</a>.</em></p> <blockquote> <h2>v1.38.1</h2> <h3>Highlights</h3> <p><a href="https://redirect.github.com/microsoft/playwright/issues/27071">microsoft/playwright#27071</a> - expect(value).toMatchSnapshot() deprecation announcement on V1.38 <a href="https://redirect.github.com/microsoft/playwright/issues/27072">microsoft/playwright#27072</a> - [BUG] PWT trace viewer fails to load trace and throws TypeError <a href="https://redirect.github.com/microsoft/playwright/issues/27073">microsoft/playwright#27073</a> - [BUG] RangeError: Invalid time value <a href="https://redirect.github.com/microsoft/playwright/issues/27087">microsoft/playwright#27087</a> - [REGRESSION]: npx playwright test --list prints all tests twice <a href="https://redirect.github.com/microsoft/playwright/issues/27113">microsoft/playwright#27113</a> - [REGRESSION]: No longer able to extend PlaywrightTest.Matchers type for locators and pages <a href="https://redirect.github.com/microsoft/playwright/issues/27144">microsoft/playwright#27144</a> - [BUG]can not display trace <a href="https://redirect.github.com/microsoft/playwright/issues/27163">microsoft/playwright#27163</a> - [REGRESSION] Single Quote Wrongly Escaped by Locator When Using Unicode Flag <a href="https://redirect.github.com/microsoft/playwright/issues/27181">microsoft/playwright#27181</a> - [BUG] evaluate serializing fails at 1.38</p> <h3>Browser Versions</h3> <ul> <li>Chromium 117.0.5938.62</li> <li>Mozilla Firefox 117.0</li> <li>WebKit 17.0</li> </ul> <p>This version was also tested against the following stable channels:</p> <ul> <li>Google Chrome 116</li> <li>Microsoft Edge 116</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/playwright/commit/47434209996cfd19d7c913caa7ddf8e1377e1d99"><code>4743420</code></a> chore: mark 1.38.1 (<a href="https://redirect.github.com/Microsoft/playwright/issues/27237">#27237</a>)</li> <li><a href="https://github.com/microsoft/playwright/commit/c41012b0553fd5617e902e9584273ecb79b26152"><code>c41012b</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/27219">#27219</a>): Revert "feat(evaluate): serialize map and set (<a href="https://redirect.github.com/Microsoft/playwright/issues/26730">#26730</a>)" ...</li> <li><a href="https://github.com/microsoft/playwright/commit/ed619b6fcb06a442be29b7ff48d3d91660f6742c"><code>ed619b6</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/27162">#27162</a>): fix(tracing): bump trace version to V5, migrate V4 trace...</li> <li><a href="https://github.com/microsoft/playwright/commit/abf9df39cf5ac11e2dc7f28c4b7cef0f96820c5d"><code>abf9df3</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/27188">#27188</a>): fix(locators): do not escape regular expressions with u ...</li> <li><a href="https://github.com/microsoft/playwright/commit/35d8604f8d1ad4715d6774ff0228a62d23f22ea7"><code>35d8604</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/27167">#27167</a>): docs: 1.38 release notes for language ports (<a href="https://redirect.github.com/Microsoft/playwright/issues/27168">#27168</a>)</li> <li><a href="https://github.com/microsoft/playwright/commit/6cc43d81c567f57a58ac3240fdf6797e66a2e119"><code>6cc43d8</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/27117">#27117</a>): fix: custom expect matchers on Locator/Page/APIResponse ...</li> <li><a href="https://github.com/microsoft/playwright/commit/2a577a5cafb1b2381e01169ab3954e536577de23"><code>2a577a5</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/27095">#27095</a>): fix(tracing): support old traces with consoleMessage.arg...</li> <li><a href="https://github.com/microsoft/playwright/commit/ed919f3dda06e23601df046c0c16ec160ff3c0af"><code>ed919f3</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/27098">#27098</a>): fix(har): handle invalid Expires/Max-Age (<a href="https://redirect.github.com/Microsoft/playwright/issues/27123">#27123</a>)</li> <li><a href="https://github.com/microsoft/playwright/commit/476b74f7c4b6f95ec9fe2c89d3aee20bb9a277ec"><code>476b74f</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/27103">#27103</a>): fix: list tests only once (<a href="https://redirect.github.com/Microsoft/playwright/issues/27107">#27107</a>)</li> <li><a href="https://github.com/microsoft/playwright/commit/0861364c28a354c0ad5c96b312778dc2532bf905"><code>0861364</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/27100">#27100</a>): chore: fit body in the network panel</li> <li>Additional commits viewable in <a href="https://github.com/Microsoft/playwright/compare/v1.38.0...v1.38.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When testing Dynamic Font Scaling with a custom font I noticed that the large title does not respect `--ion-font-family` on transition. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - The cloned large title now respect `--ion-font-family` Note: This happens in `main` too which is why I am merging into there instead of the Dynamic Font Scaling branch. | `main` | branch | | - | - | |  |  | ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
github-actions
bot
added
package: core
Closed
liamdebeasi
requested review from
mapsandapps,
brandyscarney,
averyjohnston,
sean-perkins and
thetaPC
as code owners
brandyscarney
approved these changes
Sep 26, 2023
sean-perkins
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
The screenshot changes here are correct:
iOS Datetime Dimensions Changing
Prior to #27641, the calendar day had a font-size of 1.25rem (20px at the default font size).
After #27641, this element had a min height of 16px instead. I changed this to
dynamic-font(16px), but there are still (good) height differences as a result of the PR.MD Datetime Dimensions Shrinking
Prior to #27641, the calendar day button had a total height of 42px that was comprised of 26px of padding (13px on top, 13px on bottom) and 16px intrinsic height from the text. As the text grew, the overall height of the calendar day button grew too.
After #27641, that extra padding was removed, and the calendar day button stayed fixed at 42px.
I initially thought this was a problem, but it actually aligns with the MD spec. The calendar day wrapper should not grow as the font size grows. Our example uses font sizes larger than what you can achieve with the font scaling feature on Android with the date picker which is why it looks a bit cramped, but the behavior is correct: