chore: sync main #28213
Closed
chore: sync main #28213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue number: Resolves #26391 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When updating the `value` programmatically on an `ion-datetime` after it has already been created: - With grid style: The selected date visually updates, but the calendar does not scroll to the newly selected month. - With wheel style: The selected date does not visually update, i.e. the wheels do not move to show the newly selected date. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Grid style datetimes now scroll to the selected date using the same animation as when clicking the next/prev month buttons. - This animation mirrors the behavior in both MUI and native iOS. See the [design doc](https://github.com/ionic-team/ionic-framework-design-documents/blob/main/projects/ionic-framework/components/datetime/0003-datetime-async-value.md) for more information and screen recordings. - The animation will not occur if the month/year did not change, or when the datetime is hidden. - Wheel style datetimes now visually update to the selected date. No animation occurs, also mirroring native. - The `parseDate` util has also had its type signatures updated to account for returning `undefined` when the date string is improperly formatted. This was missed when the util was refactored to support multiple date selection. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> - Docs PR: ionic-team/ionic-docs#3053 - While this can technically be considered a bug fix, we are merging it into a feature branch for safety; it's a fairly significant change to how datetime behaves, and may interfere with custom logic when updating a datetime's value async. - Jumping to the newly selected value is handled by replacing everything [here](https://github.com/ionic-team/ionic-framework/pull/27806/files#diff-4a407530c60e3cf72bcc11acdd21c4803a94bf47ea81b99e757db1c93d2735b8L364-L407) with `processValue()`. This covers both wheel and grid datetimes. - `activePartsClone` as a whole was also removed. It was added in #24244 to enable changing `activeParts` without triggering a rerender (and thus jumping to the new value) but since we now want to do that jump, the clone is no longer needed. - The animation code might be tricky to follow, so I recorded going through it: https://github.com/ionic-team/ionic-framework/assets/90629384/1afa5762-f493-441a-b662-f0429f2d86a7
chore: sync with main
chore: sync with main
#28075) Co-authored-by: Liam DeBeasi <[email protected]> Co-authored-by: ionitron <[email protected]>
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 4.1.0 to 4.2.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>🌲 4.2.0 (2023-09-05)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> resolve implicit enum types (<a href="https://redirect.github.com/ionic-team/stencil/issues/4739">#4739</a>) (<a href="https://github.com/ionic-team/stencil/commit/f5a3bd8739a4b9eab3b8b9b1f9c808c47b2aa4fc">f5a3bd8</a>)</li> <li><strong>runtime:</strong> patch methods for scoped slot <code>append</code>, <code>prepend</code>, and <code>insertAdjacent</code> (<a href="https://redirect.github.com/ionic-team/stencil/issues/4719">#4719</a>) (<a href="https://github.com/ionic-team/stencil/commit/1d98462135a196b9d9037dd46f0e7fe55d108496">1d98462</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>typescript:</strong> upgrade to TypeScript 5.1 (<a href="https://redirect.github.com/ionic-team/stencil/pull/4718">#4718</a>) (<a href="https://github.com/ionic-team/stencil/commit/49df0e7b9bc1862d690e3239404243de1c838d6d">49df0e7</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h1>🎺 <a href="https://github.com/ionic-team/stencil/compare/v4.2.0-0...v4.2.0">4.2.0</a> (2023-09-05)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> resolve implicit enum types (<a href="https://redirect.github.com/ionic-team/stencil/issues/4739">#4739</a>) (<a href="https://github.com/ionic-team/stencil/commit/f5a3bd8739a4b9eab3b8b9b1f9c808c47b2aa4fc">f5a3bd8</a>)</li> <li><strong>runtime:</strong> patch methods for scoped slot <code>append</code>, <code>prepend</code>, and <code>insertAdjacent</code> (<a href="https://redirect.github.com/ionic-team/stencil/issues/4719">#4719</a>) (<a href="https://github.com/ionic-team/stencil/commit/1d98462135a196b9d9037dd46f0e7fe55d108496">1d98462</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>typescript:</strong> upgrade to TypeScript 5.1 (<a href="https://redirect.github.com/ionic-team/stencil/pull/4718">#4718</a>) (<a href="https://github.com/ionic-team/stencil/commit/49df0e7b9bc1862d690e3239404243de1c838d6d">49df0e7</a>)</li> </ul> <h1>🐸 <a href="https://github.com/ionic-team/stencil/compare/v4.1.0...v4.2.0-0">4.2.0-0</a> (2023-09-05)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> resolve implicit enum types (<a href="https://redirect.github.com/ionic-team/stencil/issues/4739">#4739</a>) (<a href="https://github.com/ionic-team/stencil/commit/f5a3bd8739a4b9eab3b8b9b1f9c808c47b2aa4fc">f5a3bd8</a>)</li> <li><strong>runtime:</strong> patch methods for scoped slot <code>append</code>, <code>prepend</code>, and <code>insertAdjacent</code> (<a href="https://redirect.github.com/ionic-team/stencil/issues/4719">#4719</a>) (<a href="https://github.com/ionic-team/stencil/commit/1d98462135a196b9d9037dd46f0e7fe55d108496">1d98462</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>typescript:</strong> upgrade to TypeScript 5.1 (<a href="https://redirect.github.com/ionic-team/stencil/pull/4718">#4718</a>) (<a href="https://github.com/ionic-team/stencil/commit/49df0e7b9bc1862d690e3239404243de1c838d6d">49df0e7</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/44e10d2cdfd5f7bb4c81cb24bb5e7e54a75680d0"><code>44e10d2</code></a> Release v4.2.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4758">#4758</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/817701c58f1d486ab8f9fa0cd5af809ecb75b18c"><code>817701c</code></a> Release v4.2.0-0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4757">#4757</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/1d98462135a196b9d9037dd46f0e7fe55d108496"><code>1d98462</code></a> fix(runtime): patch methods for scoped slot <code>append</code>, <code>prepend</code>, and `insertA...</li> <li><a href="https://github.com/ionic-team/stencil/commit/1567f8693a0dc10060957836ae7891975e191913"><code>1567f86</code></a> chore(snc): eliminate TS2774 errors (<a href="https://redirect.github.com/ionic-team/stencil/issues/4750">#4750</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/efa93dd450df276d421d230854b64a4992dbfc24"><code>efa93dd</code></a> chore(snc): fix a single SNC error in query-nonce-meta-tag-content.spec.ts (#...</li> <li><a href="https://github.com/ionic-team/stencil/commit/ec0778d8e4e477e047ab7400a7155c4c43d7899e"><code>ec0778d</code></a> chore(deps): update dependency postcss to v8.4.29 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4754">#4754</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/29fa192eddc7f391291f8f7441d6d6a6f572c838"><code>29fa192</code></a> chore(snc): drop snc count for serialize-css (<a href="https://redirect.github.com/ionic-team/stencil/issues/4730">#4730</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/94009485a04b18d6fa9da92b8fe5c70026719190"><code>9400948</code></a> chore(deps): update dependency <code>@rollup/pluginutils</code> to v5.0.4 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4742">#4742</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/0f2db7dfa1bcb20775e01c0777eb96b91433cac6"><code>0f2db7d</code></a> chore(deps): update dependency <code>@types/node</code> to v20.5.6 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4731">#4731</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/1482bc8b0a632bfc9c7b45bb1a00c02bd10126c4"><code>1482bc8</code></a> chore(deps): update dependency <code>@types/listr</code> to v0.14.5 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4751">#4751</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v4.1.0...v4.2.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Issue number: resolves #25340 --------- - Exposes the following parts for a calendar day: `calendar-day`, `today`, and `active` - Combines the `calendar-day-highlight` element with the `calendar-day` element so developers don't have to know to style two different elements & we don't have to expose them as separate parts - Improves height parity of the calendar day across browsers - Updates the `custom` e2e test to include an example of styling days using the newly exposed CSS parts - Adds tests for the focus states of the calendar day
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When the "Update Reference Screenshot" job is run but no new screenshots are generated, the following error is logged: ``` nothing added to commit but untracked files present (use "git add" to track) Error: Process completed with exit code 1. ``` This is happening because there are no files to commit when running `git commit`. Brandy noted that this was confusing since it doesn't actually tell you why there are no files to commit. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - If there are no diffs to commit then the update screenshot script will log a message saying that no screenshot diffs were generated. Example: ```⚠️ Error: No new screenshots generated⚠️ This means that there were zero visual diffs when running screenshot tests. Make sure you have pushed any code changes that would result in visual diffs. ``` https://github.com/ionic-team/ionic-framework/actions/runs/6099399582/job/16552017414 ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The `--ion-safe-area-left` and `--ion-safe-area-right` variables in `ion-menu` are being set as if they use the app's direction. It's been determined that safe area is not logical and uses the device's direction. The current implementation is adding padding in the wrong sides for `ion-toolbar` and `ion-content` within a `ion-menu`. Additionally, `ion-menu` does not use the entire screen so the safe area only needs to be applied to the side that is touching the device screen. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Set the `--ion-safe-area-left` and `--ion-safe-area-right` variables to the correct values based on the device's direction. - Padding is only added to the side that is not in the safe area. - `ion-toolbar` is adding `--ion-safe-area-left` and `--ion-safe-area-right` based on the device's direction. - `ion-toolbar` can now inherit the correct values from `--ion-safe-area-left` and `--ion-safe-area-right`. - `ion-content` can now inherit the correct values from `--ion-safe-area-left` and `--ion-safe-area-right`. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: 7.3.4-dev.11694015543.18bc484f
Issue number: resolves #28137 --------- Changes according to [this comment](#28137 (comment)) ## Does this introduce a breaking change? - [ ] Yes - [x] No @liamdebeasi Sorry for replacing the previous PR. I only copied the main branch to my fork so I couldn't rebase properly. I am unfortunately not extremely familiar with Github. --------- Co-authored-by: Philipp Heuer <[email protected]> Co-authored-by: Liam DeBeasi <[email protected]>
…8.2 in /core (#28149) Bumps [@stencil/angular-output-target](https://github.com/ionic-team/stencil-ds-output-targets) from 0.7.1 to 0.8.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil-ds-output-targets/releases"><code>@stencil/angular-output-target</code>'s releases</a>.</em></p> <blockquote> <h2><code>@stencil/angular-output-target</code><a href="https://github.com/0"><code>@0</code></a>.8.2</h2> <h2>What's Changed</h2> <ul> <li>fix(angular-output-target): rewrite nested generics for custom events by <a href="https://github.com/sean-perkins"><code>@sean-perkins</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/pull/371">ionic-team/stencil-ds-output-targets#371</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/ionic-team/stencil-ds-output-targets/compare/@stencil/[email protected]...@stencil/[email protected]">https://github.com/ionic-team/stencil-ds-output-targets/compare/<code>@stencil/angular-output-target</code><code>@0.8.1...</code><code>@stencil/angular-output-target</code><code>@0.8.2</code></a></p> <h2><code>@stencil/angular-output-target</code><a href="https://github.com/0"><code>@0</code></a>.8.1</h2> <h2>What's Changed</h2> <ul> <li>fix(angular-output-target): multiple targets do not overwrite each other by <a href="https://github.com/sean-perkins"><code>@sean-perkins</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/pull/376">ionic-team/stencil-ds-output-targets#376</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/ionic-team/stencil-ds-output-targets/compare/@stencil/[email protected]...@stencil/[email protected]">https://github.com/ionic-team/stencil-ds-output-targets/compare/<code>@stencil/angular-output-target</code><code>@0.8.0...</code><code>@stencil/angular-output-target</code><code>@0.8.1</code></a></p> <h2><code>@stencil/angular-output-target</code><a href="https://github.com/0"><code>@0</code></a>.8.0</h2> <h2>What's Changed</h2> <ul> <li>feat(angular-output-target): generate standalone components by <a href="https://github.com/sean-perkins"><code>@sean-perkins</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/pull/367">ionic-team/stencil-ds-output-targets#367</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/ionic-team/stencil-ds-output-targets/compare/@stencil/[email protected]...@stencil/[email protected]">https://github.com/ionic-team/stencil-ds-output-targets/compare/<code>@stencil/angular-output-target</code><code>@0.7.1...</code><code>@stencil/angular-output-target</code><code>@0.8.0</code></a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/afe862ef6033408413cab16224c195ec5acc0e0c"><code>afe862e</code></a> chore(angular-output-target): manually bumping the package version (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/387">#387</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/126dc39e5b7427a9efc2a57442e02b8ca43675bc"><code>126dc39</code></a> fix(angular-output-target): rewrite nested generics for custom events (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/372">#372</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/d37ebd7955ccdfd679f16a555c354fd0d02207cc"><code>d37ebd7</code></a> chore(deps): update actions/checkout action to v4 (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/386">#386</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/7dabd06b2df96fc76718f69e0550ae481381f15b"><code>7dabd06</code></a> chore(deps): update actions/checkout action to v3.6.0 (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/384">#384</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/0b022bc2efccc544c226e464f51c8e21c4f58654"><code>0b022bc</code></a> chore(deps): update actions/setup-node action to v3.8.1 (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/380">#380</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/c23bbfbbca73046a7f809395ce6db632a22b94a3"><code>c23bbfb</code></a> chore(angular-output-target): manually bumping the package version (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/377">#377</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/3c6a3252c762618799dac60d78a3b6cafe983604"><code>3c6a325</code></a> fix(angular-output-target): multiple targets do not overwrite each other (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/376">#376</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/2de5d649c3be2620d8eaaa15aafa2f76e41753fa"><code>2de5d64</code></a> chore(deps): update actions/setup-node action to v3.8.0 (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/375">#375</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/ae79bf76516daa33da1fc3052a78d8b3b678b8c2"><code>ae79bf7</code></a> chore(angular-output-target): manually bumping the package version (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/373">#373</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/01c9c098193c7c020be060851e5cc970d2702e82"><code>01c9c09</code></a> chore: publish-npm workflow uses local lerna version (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/371">#371</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil-ds-output-targets/compare/@stencil/[email protected]...@stencil/[email protected]">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
chore: sync with main
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 4.2.0 to 4.2.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>😀 v4.2.1 (2023-09-11)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> add heritage clauses earlier in native transform (<a href="https://redirect.github.com/ionic-team/stencil/issues/4769">#4769</a>) (<a href="https://github.com/ionic-team/stencil/commit/9a92ad12f628a5c2eae3048bda983fed2bc140b5">9a92ad1</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h2>🌝 <a href="https://github.com/ionic-team/stencil/compare/v4.2.0...v4.2.1">4.2.1</a> (2023-09-11)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> add heritage clauses earlier in native transform (<a href="https://redirect.github.com/ionic-team/stencil/issues/4769">#4769</a>) (<a href="https://github.com/ionic-team/stencil/commit/9a92ad12f628a5c2eae3048bda983fed2bc140b5">9a92ad1</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/29fa4b38c4ae9a5e2d1efc19a0ed50c6df9a14ca"><code>29fa4b3</code></a> v4.2.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4780">#4780</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/9a92ad12f628a5c2eae3048bda983fed2bc140b5"><code>9a92ad1</code></a> fix(compiler): add heritage clauses earlier in native transform (<a href="https://redirect.github.com/ionic-team/stencil/issues/4769">#4769</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/9ee02c518f7b5cb06001016c7cfcb62ba591d68f"><code>9ee02c5</code></a> chore(deps): update typescript-eslint to v6.6.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4777">#4777</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/9229a6203320344a5aac389fd0b0e8e7f9d5861a"><code>9229a62</code></a> chore(deps): update actions/upload-artifact action to v3.1.3 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4773">#4773</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/25fcaa9e8e1a494fd05c5c01b20c5525669d5114"><code>25fcaa9</code></a> chore(deps): update dependency terser to v5.19.4 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4774">#4774</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/81a1e2c67c849db792eca9f9ad6fae2d1e6e5ef5"><code>81a1e2c</code></a> chore(deps): update node.js to v20.6.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4776">#4776</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/f4724f6341cd209f28b0239c89df12136f15030a"><code>f4724f6</code></a> chore(deps): update actions/checkout action to v4 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4778">#4778</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/a1ab21bdebdbbfebc31bdf8a6dd8eac5ed560be7"><code>a1ab21b</code></a> chore(deps): update dependency npm to v10 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4766">#4766</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/dd1fe1d0b01723ef4d88f5eb24d34eae0cf7ac1c"><code>dd1fe1d</code></a> chore(deps): update node.js to v20.5.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4607">#4607</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/4d8ff009156b33d93daa3decad73b48c186fe7b9"><code>4d8ff00</code></a> refactor(compiler): use updateConstructor in lazy transform (<a href="https://redirect.github.com/ionic-team/stencil/issues/4768">#4768</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v4.2.0...v4.2.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Release 7.3.4
chore: sync with main
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> We checked `git diff` to see if new screenshots were generated. If no new screenshots were generated then we print a user-friendly message informing the dev what happened. However, `git diff` does not account for untracked changes (i.e. new screenshots). As a result, this prevented new screenshots from being committed. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - To fix this we use the `-N` flag which is short for `--intent-to-add`. This adds an entry with no content which causes the new screenshots to show up when running `git diff`. We later add the contents of the image. Example test run of this working: https://github.com/ionic-team/ionic-framework/actions/runs/6174263712/job/16759260534 ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
chore: sync with main
Release 7.4
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 4.2.1 to 4.3.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>🎱 4.3.0 (2023-09-18)</h2> <h2>Bug Fixes</h2> <ul> <li><strong>compiler:</strong> restrict config extras slot fix flags (<a href="https://redirect.github.com/ionic-team/stencil/issues/4767">#4767</a>) (<a href="https://github.com/ionic-team/stencil/commit/f2c322959c13400b1a17bb698ae3ee37295ab08d">f2c3229</a>)</li> <li><strong>test:</strong> ensure legacy decorators are used when using transpile (<a href="https://redirect.github.com/ionic-team/stencil/issues/4771">#4771</a>) (<a href="https://github.com/ionic-team/stencil/commit/2ef9ec7549930ef2b9fcfeba11374c8a543ed36f">2ef9ec7</a>)</li> </ul> <h2>Features</h2> <ul> <li><strong>compiler:</strong> computed properties can be used with Stencil decorators (<a href="https://redirect.github.com/ionic-team/stencil/issues/4746">#4746</a>) (<a href="https://github.com/ionic-team/stencil/commit/a848269f9883d68a44237caae469cd8a3ba5fa65">a848269</a>)</li> <li><strong>runtime:</strong> watch native HTML attributes (<a href="https://redirect.github.com/ionic-team/stencil/issues/4760">#4760</a>) (<a href="https://github.com/ionic-team/stencil/commit/fc86c23e3bf690b19fa84d8bb34e7da4598291dc">fc86c23</a>)</li> </ul> <h2>Thanks</h2> <p>🎉 Thanks <a href="https://github.com/louis-bompart">louis-bompart</a> for their contributions! 🎉</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h1>🎱 <a href="https://github.com/ionic-team/stencil/compare/v4.2.1...v4.3.0">4.3.0</a> (2023-09-18)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> restrict config extras slot fix flags (<a href="https://redirect.github.com/ionic-team/stencil/issues/4767">#4767</a>) (<a href="https://github.com/ionic-team/stencil/commit/f2c322959c13400b1a17bb698ae3ee37295ab08d">f2c3229</a>)</li> <li><strong>test:</strong> ensure legacy decorators are used when using transpile (<a href="https://redirect.github.com/ionic-team/stencil/issues/4771">#4771</a>) (<a href="https://github.com/ionic-team/stencil/commit/2ef9ec7549930ef2b9fcfeba11374c8a543ed36f">2ef9ec7</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>compiler:</strong> computed properties can be used with Stencil decorators (<a href="https://redirect.github.com/ionic-team/stencil/issues/4746">#4746</a>) (<a href="https://github.com/ionic-team/stencil/commit/a848269f9883d68a44237caae469cd8a3ba5fa65">a848269</a>)</li> <li><strong>runtime:</strong> watch native HTML attributes (<a href="https://redirect.github.com/ionic-team/stencil/issues/4760">#4760</a>) (<a href="https://github.com/ionic-team/stencil/commit/fc86c23e3bf690b19fa84d8bb34e7da4598291dc">fc86c23</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/7a1f32c145a39c86d7daa262ce6743f32eb9d7ce"><code>7a1f32c</code></a> v4.3.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4807">#4807</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/4bfe589f6d62fe38b9709eb2bf4e99b4b7b96764"><code>4bfe589</code></a> chore(deps): update dependency eslint-plugin-jsdoc to v46.8.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4803">#4803</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/13d76048c0379e04a38bfe970ca853648d30858e"><code>13d7604</code></a> chore(deps): update dependency cspell to v7.3.6 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4802">#4802</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/9d8033e9341a69a6de3bcd57e7e7c00618e777f1"><code>9d8033e</code></a> chore(deps): update dependency <code>@types/semver</code> to v7.5.2 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4801">#4801</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/ac1192fc92db8244cf269b972c0c45ddec1cbb2d"><code>ac1192f</code></a> chore(deps): update dependency <code>@types/fs-extra</code> to v11.0.2 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4800">#4800</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/c0d17ef80e1e31790c9aa83f8e2dddb943b0e903"><code>c0d17ef</code></a> chore(deps): update dependency <code>@types/node</code> to v20.6.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4806">#4806</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/75a12c0d6f879693f6f04513ee8a66adad982e7e"><code>75a12c0</code></a> chore(deps): update typescript-eslint to v6.7.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4805">#4805</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/dff9feb154c1f192d9a3a51b2d7c428635ede606"><code>dff9feb</code></a> chore(jsdoc): add jsdoc to TestingRunOptions (<a href="https://redirect.github.com/ionic-team/stencil/issues/4786">#4786</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/f94053843317426161cc8699485e848202549196"><code>f940538</code></a> test(delegates-focus): re-enable test (<a href="https://redirect.github.com/ionic-team/stencil/issues/4796">#4796</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/162508748c0515395558bcb7c18cc2b03c5d9445"><code>1625087</code></a> chore(snc): replace addtl config arg types (<a href="https://redirect.github.com/ionic-team/stencil/issues/4797">#4797</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v4.2.1...v4.3.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> We currently use retries on CI to help catch flaky tests. However, retries are enabled even when testing locally. This is not ideal because a failing test will be re-run multiple times before erroring out which increases the time it takes to run tests locally. I typically write tests before fixes so I can verify my test is checking the correct behavior. In this case I don't need it to be re-run twice -- I already know it's supposed to fail. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Test retries are only enabled on CI ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Issue number: resolves #28180 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When presenting an overlay, we remove the root (usually `ion-router-outlet`) from the accessibility tree. This makes it so you cannot accidentally focus elements behind the overlay. When dismissing an overlay we re-add the root to the accessibility tree. However, we fail to consider if there are multiple presented overlays. For example, if you present a modal, then an alert, then dismiss the alert, then the root is re-added to the accessibility tree even though the modal is still presented. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - The root is now re-added to the accessibility tree only if it is the last presented overlay. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.4.1-dev.11694783260.13da477f`
#28169) Issue number: Part of #22940 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> While working on a fix for #22940, I discovered another bug that impacted the reliability of my proposed fix for #22940. When we compute the scroll data (i.e. how much the input needs to be scrolled by), we subtract the `keyboardHeight` from the `platformHeight` (i.e. the viewport height): https://github.com/ionic-team/ionic-framework/blob/1015c06cbef4ceb10d43e722157c04844d984509/core/src/utils/input-shims/hacks/scroll-data.ts#L34 Every time we tap between inputs (even if the keyboard is already open) we re-run scroll assist because the newly focused input could be partially obscured by the keyboard. However, in this case we scroll by too much because we effectively subtract the keyboard height twice. This is because by the time we compute `platformHeight`, the platform dimensions have already shrunk to account for the keyboard (when the webview resizes). As a result, when we subtract `keyboardHeight` we get a visible area that is much smaller than the actual visible area. Examples below with different resize modes. Notice that with the "Native" resize mode (entire webview resizes when keyboard is open) tapping into other inputs scrolls the content by much more than it needs to. | Body | Native | Ionic | None | | - | - | - | - | | <video src="https://github.com/ionic-team/ionic-framework/assets/2721089/06d1cd20-0349-4a59-ad85-c1c8a8a03caa"></video> | <video src="https://github.com/ionic-team/ionic-framework/assets/2721089/1d4e8363-a69b-45c4-931c-d6227e548ec9"></video> | <video src="https://github.com/ionic-team/ionic-framework/assets/2721089/7e4304c1-7d56-48c8-aed8-16fc7e51641a"></video> | <video src="https://github.com/ionic-team/ionic-framework/assets/2721089/7869c5e0-b202-46e1-af82-49e41b3b067e"></video> | ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - We now compute the viewport height on load rather than on focus. This ensures that we always use the full viewport height when computing the visible area. | Body | Native | Ionic | None | | - | - | - | - | | <video src="https://github.com/ionic-team/ionic-framework/assets/2721089/c5a66287-0cad-42db-bece-da16edad60e3"></video> | <video src="https://github.com/ionic-team/ionic-framework/assets/2721089/372a45c8-e8bd-43d2-bf50-d87b7250e9b3"></video> | <video src="https://github.com/ionic-team/ionic-framework/assets/2721089/3d656467-8e2e-48cc-8d72-dc89a67ef8b1"></video> | <video src="https://github.com/ionic-team/ionic-framework/assets/2721089/19969535-7d06-404c-98e4-ae49957e0ffe"></video> | ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.3.4-dev.11694548895.1578981b`
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> I needed this constant for a different PR but realized the docs were outdated: https://github.com/ionic-team/ionic-framework/blob/81714d45bd97f0ba91729959b60a0dc1d1d06533/core/src/utils/test/playwright/viewports/index.ts ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Docs reference correct constant name ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Issue number: resolves #22940 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Scroll assist does not run when changing keyboards. This means that inputs can be hidden under the keyboard if the new keyboard is larger than the previous keyboard. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - On Browsers/PWAs scroll assist will re-run when the keyboard geometry changes. We don't have a cross-browser way of detecting keyboard changes yet, so this is the best we have for now. - On Cordova/Capacitor scroll assist will re-run when the keyboard changes, even if the overall keyboard geometry does not change. In the example below, we are changing keyboards while an input is focused: | `main` | branch | | - | - | | <video src="https://github.com/ionic-team/ionic-framework/assets/2721089/715e176a-6724-4308-ae3e-15b5bea308ac"></video> | <video src="https://github.com/ionic-team/ionic-framework/assets/2721089/b9ccd482-720a-409b-a089-b3330c1e405c"></video> | Breakdown per-resize mode: | Native | None | Ionic | Body | | - | - | - | - | | <video src="https://github.com/ionic-team/ionic-framework/assets/2721089/b930ac5f-3398-4887-a8ca-a57708adc66d"></video> | <video src="https://github.com/ionic-team/ionic-framework/assets/2721089/68465854-94d0-4e00-940c-c4674a43b6a3"></video> | <video src="https://github.com/ionic-team/ionic-framework/assets/2721089/561f313a-9caf-4c9e-ab15-9c4383f0e3ee"></video> | <video src="https://github.com/ionic-team/ionic-framework/assets/2721089/300b8894-ad2a-43bc-8e82-ecd68afd407e"></video> | ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.3.4-dev.11694706860.14b2710d` --------- Co-authored-by: Amanda Johnston <[email protected]>
Issue number: resolves #27199 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When using the modern range in an item, the knob will get cut off by the item when the value is at either the min or the max. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Range knob is no longer cut off by the item ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> This is an extension of #27188. I decided to make a separate branch/PR since I added tests and changed the implementation a bit. Feel free to take all/some/none of this code. --------- Co-authored-by: Sean Perkins <[email protected]> Co-authored-by: ionitron <[email protected]>
…#28136) Issue number: Resolves #27169 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Clicking the padded space within an `ion-item` will not pass the click event to the slotted `ion-radio`, `ion-checkbox`, `ion-select` or `ion-toggle`. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - The padded space at the start of `.item-native` and at the end of `.item-inner` is clickable to activate a control. - When the item is clicked, we check if the event is a result of clicking the control or clicking the item's padded space. If the click event is on the control, we don't need to do anything and let the default behavior occur. If the click event is on the padded space, we manually call the `.click()` method for the interactive element. - The cursor pointer displays when hovering over the padded space when a slotted interactive control is present. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Release 7.4.1
…27821) Issue number: Resolves #27798 --------- ## What is the current behavior React IonNav component's views are missing keys, leading to unnecessary duplicate mounting of components. ## What is the new behavior? - Adds key to views of React IonNav component. ## Does this introduce a breaking change? - [ ] Yes - [x] No --------- Co-authored-by: Sean Perkins <[email protected]>
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Some of the tests for `item-sliding` were being skipped due to flakiness. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Updated the tests to use the stable function, `dragElementBy` to handle gestures, removing the gesture flakiness. - Separated the basic test to lessen the gesture complexity else it becomes flaky since it can't handle opening and closing and opening in the same test. - Tests are now checking all modes and all directions. - Updated a utils function with a warning regarding an open issue with RTL. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> N/A --------- Co-authored-by: ionitron <[email protected]> Co-authored-by: Brandy Carney <[email protected]>
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> CI is failing for Cypress apps due to cypress-io/cypress#27804 (comment). ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - All Cypress test apps have been updated to Cypress 13.2.0 which is not affected by this issue. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
github-actions
bot
added
package: core
brandyscarney
requested review from
mapsandapps,
liamdebeasi,
averyjohnston,
sean-perkins and
thetaPC
as code owners
|
Closing in favor of #28238 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges branch
mainintoFW-4146There were merge conflicts with
rangewhich I resolved and then had to fix an issue where the calculation couldn't be done because it was adding different units (remandpx) which I fixed here: 52e311fScreenshot updates are here: c126471