-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Disable a single step of history recording for the next view displayed by specifying nextViewOptions.disableHistory. #3318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
whydoidoit
wants to merge
3,721
commits into
ionic-team:master
from
whydoidoit:optionally-disable-history
Closed
Disable a single step of history recording for the next view displayed by specifying nextViewOptions.disableHistory. #3318
whydoidoit
wants to merge
3,721
commits into
ionic-team:master
from
whydoidoit:optionally-disable-history
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perf(infiniteScroll): Use isolate scope
This change makes the DelegateService available on the ionic namespace. It is useful so external directives can follow the delegate pattern set by the framework itself.
Improves tap behaviours on iPad by reducing “missclicks”
…crease refactor(tap): increase tap release tolerance
Fix IE10 scroll issue. This addresses ionic-team#2728
docs($ionicPlatform): list back button priorities
docs(statusbar): requirements for statusbar methods
fix(tab): set $scope.$tabSelected when nested tabs selected
fix(subHeader): removes borders on android subheaders
It's a hack, but it's the best we can do right now.
Refactored to create a `changeValidator` object that will properly tell you if a resize or a data change requires a refresh. Closes ionic-team#3299.
Addresses ionic-team#3274. These dependencies should not be in bower.json because they are not used in Ionic. Many people's build processes pull in all of these and automatically bundle them into the browser. If they do that, it will break with the addition of `scenario` and `mocks`. Additionally, we will add unneeded overhead with `aria`, `messages` and `resources`.
…d by specifying nextViewOptions.disableHistory. This is useful when a root view takes you forward, but subsequent steps forward from the child should return to the root. An example of this is: Root is a list of available messages. Tapping one takes you to a message display, which also contains a list of related messages. If you record history and keep stepping through children you end up with a crazy history stack which is not what the user wants. Pressing Back should return them to the root of the messages. Adding this to nextViewOptions as disableHistory especially helps when using URL route switches to facilitate dynamic loading of states from the file system.
I think this would be exceptionally helpful for those with complex nested/abstract states. I think it'd also be useful as an attribute on the $stateProvider: E.g:
|
+1 |
Links to this: #3418 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when a root view takes you forward, but subsequent steps forward from the child should return to the root.
An example of this is:
Root is a list of available messages. Tapping one takes you to a message display, which also contains a list of related messages. If you record history and keep stepping through children you end up with a crazy history stack which is not what the user wants. Pressing Back should return them to the root of the messages.
Adding this to nextViewOptions as disableHistory especially helps when using URL route switches to facilitate dynamic loading of states from the file system.