Skip to content

rust-ipfs is no longer being maintained. #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TMoMoreau
Copy link
Contributor

@TMoMoreau TMoMoreau commented Jan 25, 2023

Describe your changes

rust-ipfs is no longer being maintained. Updated the list of implementations to include a note to reflect this. I did not remove the item in the table or the link to the archived repo.

There is likely to be more mentions of rust-ipfs elsewhere, I'll crawl the docs to find them and add them to this PR.

Exhaustive manual crawling of every page of the docs shows there are no other mentions of rust-ipfs (except for what is being addressed in PR #1446)

  • Find other mentions of rust-ipfs
  • Add a note to them that rust-ipfs is no longer maintained (possibly remove entirely)

Files changed

  • docs/concepts/ipfs-implementatios.md

What issue(s) does this address?

Does this update depend on any other PRs?

Checklist before requesting a review

  • Passing the beta version of the Check Markdown links for modified files check. Action results can be viewed here.

Checklist before merging

  • Passing all required checks (The beta Check Markdown links for modified files check is not required)

@TMoMoreau TMoMoreau linked an issue Jan 25, 2023 that may be closed by this pull request
@TMoMoreau TMoMoreau changed the title Add note to the rust-ipfs item in the ipfs-implementations list rust-ipfs is no longer being maintained. Jan 25, 2023
@TMoMoreau
Copy link
Contributor Author

@ElPaisano Do you think this bold note that rust-ipfs is no longer being maintained is enough?

@TMoMoreau
Copy link
Contributor Author

Ah, I just remembered this issue exists: #1360

Getting that issue done should take priority over this one, and would also render this PR pointless.

@ElPaisano
Copy link
Contributor

ElPaisano commented Jan 26, 2023

Ah, I just remembered this issue exists: #1360

Getting that issue done should take priority over this one, and would also render this PR pointless.

Ahhhh ok I see that. I do like the reorg proposal better than just deleting them

However, out https://docs.ipfs.tech/basics/ipfs-implementations/, it would still make sense to remove other mentions of rust-ipfs. So it seems like this PR might still be relevant, just scoped down

@TMoMoreau
Copy link
Contributor Author

We can go ahead and get this merged, just need a quick approval. As mentioned in the original comment, there are no other mentions of rust-ipfs in the docs, (other than what was addressed in #1456, which has been merged.)

@TMoMoreau TMoMoreau requested a review from ElPaisano February 8, 2023 04:52
@TMoMoreau
Copy link
Contributor Author

Oh, right, this PR is now redundant because of #1456, closing.

@TMoMoreau TMoMoreau closed this Feb 8, 2023
@TMoMoreau TMoMoreau deleted the IPFS-implementations--rust-ipfs branch February 8, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust-ipfs is no longer maintained, update docs
2 participants