Repository navigation
refactor(router): delete the dead scheduling policy and the dummy shared cache - #144
Closed
ishandhanani wants to merge 1 commit into
Closed
ishandhanani wants to merge 1 commit into
ishandhanani wants to merge 1 commit into
Conversation
ishandhanani
had a problem deploying
to
external_collaborator
October 31, 2026 09:24 — with
GitHub Actions
Failure
ishandhanani
force-pushed
the
idhanani/dyn-180-drop-dead-policy-shared-cache
branch
from
October 31, 2026 09:24
952c217 to
76c76cc
Compare
ishandhanani
had a problem deploying
to
external_collaborator
October 31, 2026 09:24 — with
GitHub Actions
Failure
ishandhanani
force-pushed
the
idhanani/dyn-180-drop-dead-policy-shared-cache
branch
from
October 31, 2026 09:25
76c76cc to
3f879ab
Compare
ishandhanani
had a problem deploying
to
external_collaborator
October 31, 2026 09:25 — with
GitHub Actions
Failure
…red cache
Step 7a of the router split (DYNO-180). lib/kv-router/src/scheduling/
policy.rs (FcfsPolicy, WsptPolicy, RouterSchedulingPolicy, the
SchedulingPolicy trait) has no user: the queue actor took its policy
from the admission stage's PolicyQueue long ago and only lib.rs still
re-exported the four names. services/shared_cache/{mod,server}.rs, the
in-memory dummy shared KV cache server, has no caller in the tree, the
Python bindings, the components, or the docs. Both go, with the
ordered-float dependency the policy module alone used and the README
line that listed the shared-cache service under standalone-indexer.
Validation: kv-router tests 225 + 2 + 7 under
standalone-selection,standalone-slot-tracker,metrics,testing (241 before:
the deleted modules' 16 tests), 119 default (133), 141 slot-tracker only
(155), standalone_indexer_http 7; clippy -D warnings on kv-router (five
feature sets), dynamo-llm, mocker, ext-proc, sglang-sidecar, builtin
(tests and benches), dynamo-bench, the six example crates; lib/llm
kv_router 485; router layering gate 26 checks; codeowners strict after
pruning the shared_cache glob and regenerating CODEOWNERS; fmt. The
Python bindings check fails on a type mismatch that predates this change
(5d-1, startup_policy_parameters takes the selection slice); fixed in the
next PR of the stack.
Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
ishandhanani
force-pushed
the
idhanani/dyn-180-drop-dead-policy-shared-cache
branch
from
November 2, 2026 13:31
3f879ab to
11b0293
Compare
ishandhanani
had a problem deploying
to
external_collaborator
November 2, 2026 13:31 — with
GitHub Actions
Failure
Owner
Author
|
Landed upstream as ai-dynamo#18055 (squash commit 79692cf on main, 2026-11-11). Closing this fork review unit. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 7a of the router split v2 (DYNO-180). Stacked on #143. Step 7 thins
lib/kv-routerto the composition crate; this first PR is the pure deletion the plan row lists: the dead scheduling policy module and the dummy shared-cache server.Summary
lib/kv-router/src/scheduling/policy.rs(446 lines:SchedulingPolicytrait,FcfsPolicy,WsptPolicy,RouterSchedulingPolicy, their tests). The queue actor orders by the admission stage'sPolicyQueue; the only reference to these names was thelib.rsre-export, removed with it.ordered-floatleaves the kv-router manifest (this module was its only user; the lockfile entry stays for other crates).lib/kv-router/src/services/shared_cache/{mod,server}.rs(276 lines: the in-memorycheck_blocksdummy server understandalone-indexer). No caller inlib/,components/,deploy/,docs/, or the Python bindings.services/mod.rsand the README feature list drop the entry. The kernel'sSharedKvCachehook and the flatshared_cache_*settings are unrelated and untouched.Validation
cargo test -p dynamo-kv-routerwithstandalone-selection,standalone-slot-tracker,metrics,testing: 225 + 2 + 7 (241 before; the deleted modules carried 14 policy tests and 2 shared-cache tests); default 119 (133);standalone-slot-trackeronly 141 (155);--test standalone_indexer_httpunderstandalone-indexer,metrics: 7.cargo clippy -D warnings --all-targets: kv-router (full, default, slot-tracker only, indexer only, selection only),dynamo-llm -p dynamo-mocker -p dynamo-ext-proc -p dynamo-sglang-sidecar -p dynamo-custom-policy-builtin --tests --benches,dynamo-bench --tests;cargo checkon the six custom-policy example crates.cargo test -p dynamo-llm kv_router485.scripts/router_layering_check.sh: 26 checks, 0 failures.build_codeowners.py --strictpasses after pruning thelib/kv-router/src/services/shared_cache/glob fromareas.yamland regeneratingCODEOWNERS.cargo fmt --all -- --checkclean.cargo checkonlib/bindings/python(kv-indexer,slot-tracker,select-service) fails on a type mismatch this PR does not touch:startup_policy_parametershas taken&SelectionConfigsince 5d-1 (refactor(router): give worker selection its own config slices #124) andentrypoint.rs:288still passes the flat config. The next PR of the stack fixes it; the bindings check joins every step's chain from here.