Repository navigation
fix(bindings): pass the selection slice to the builtin policy parameters - #145
Closed
ishandhanani wants to merge 1 commit into
Closed
ishandhanani wants to merge 1 commit into
ishandhanani wants to merge 1 commit into
Conversation
ishandhanani
had a problem deploying
to
external_collaborator
October 31, 2026 09:25 — with
GitHub Actions
Failure
lib/bindings/python is outside the workspace, so cargo check --workspace never compiled it after 5d-1 (DYNO-177) changed dynamo_custom_policy_builtin::startup_policy_parameters to take the worker-selection config slice. entrypoint.rs still passed the flat KvRouterConfig; it now converts with SelectionConfig::from, as the builtin plugin's own callers do. The bindings lockfile catches up with the router crates the split added since step 1 (it had none of them). The bindings cargo check is part of every router-split validation chain from here (DYNO-180). Validation: cd lib/bindings/python && cargo check --features kv-indexer,slot-tracker,select-service; cargo clippy with the same features -D warnings; both clean. Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
ishandhanani
force-pushed
the
idhanani/dyn-177-bindings-selection-slice
branch
from
November 2, 2026 13:31
b1b8f86 to
2b6bb62
Compare
ishandhanani
had a problem deploying
to
external_collaborator
November 2, 2026 13:31 — with
GitHub Actions
Failure
Owner
Author
|
Landed upstream as ai-dynamo#18055 (squash commit 79692cf on main, 2026-11-11). Closing this fork review unit. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #144. A stack defect found when the Python bindings
cargo checkjoined the router-split validation chain (DYNO-180).Summary
lib/bindings/python/rust/llm/entrypoint.rs:startup_policy_parametershas taken&SelectionConfigsince 5d-1 (refactor(router): give worker selection its own config slices #124, DYNO-177); the bindings still passed&KvRouterConfig. The call now converts withSelectionConfig::from(&self.inner), as the builtin plugin's own callers do.lib/bindings/python/Cargo.lock: catches up with the router crates the split added since step 1 (the bindings lockfile had none of them because the crate is outside the workspace and nothing regenerated it).Validation
cd lib/bindings/python && cargo check --features kv-indexer,slot-tracker,select-service: clean (failed withexpected &SelectionConfig, found &KvRouterConfigbefore).cargo clippy --features kv-indexer,slot-tracker,select-service -- -D warningsin the same directory: clean.