Skip to content

fix(bindings): pass the selection slice to the builtin policy parameters - #145

Closed
ishandhanani wants to merge 1 commit into
idhanani/dyn-180-drop-dead-policy-shared-cachefrom
idhanani/dyn-177-bindings-selection-slice
Closed

ishandhanani wants to merge 1 commit into
idhanani/dyn-180-drop-dead-policy-shared-cachefrom
idhanani/dyn-177-bindings-selection-slice

Conversation

@ishandhanani

Copy link
Copy Markdown
Owner

Stacked on #144. A stack defect found when the Python bindings cargo check joined the router-split validation chain (DYNO-180).

Summary

  • lib/bindings/python/rust/llm/entrypoint.rs: startup_policy_parameters has taken &SelectionConfig since 5d-1 (refactor(router): give worker selection its own config slices #124, DYNO-177); the bindings still passed &KvRouterConfig. The call now converts with SelectionConfig::from(&self.inner), as the builtin plugin's own callers do.
  • lib/bindings/python/Cargo.lock: catches up with the router crates the split added since step 1 (the bindings lockfile had none of them because the crate is outside the workspace and nothing regenerated it).

Validation

  • cd lib/bindings/python && cargo check --features kv-indexer,slot-tracker,select-service: clean (failed with expected &SelectionConfig, found &KvRouterConfig before).
  • cargo clippy --features kv-indexer,slot-tracker,select-service -- -D warnings in the same directory: clean.

lib/bindings/python is outside the workspace, so cargo check --workspace
never compiled it after 5d-1 (DYNO-177) changed
dynamo_custom_policy_builtin::startup_policy_parameters to take the
worker-selection config slice. entrypoint.rs still passed the flat
KvRouterConfig; it now converts with SelectionConfig::from, as the
builtin plugin's own callers do. The bindings lockfile catches up with
the router crates the split added since step 1 (it had none of them).

The bindings cargo check is part of every router-split validation chain
from here (DYNO-180).

Validation: cd lib/bindings/python && cargo check --features
kv-indexer,slot-tracker,select-service; cargo clippy with the same
features -D warnings; both clean.

Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
@ishandhanani

Copy link
Copy Markdown
Owner Author

Landed upstream as ai-dynamo#18055 (squash commit 79692cf on main, 2026-11-11). Closing this fork review unit.

This branch had an error being deployed

1 failed deployment
external_collaborator — 2b6bb62a Deployed Nov 2, 2026 by ishandhanani via ok-to-test #490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant