Added new reserved char and fixing studio tests #1196
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR adds the '@' character to the reserved character sets for dataset, namespace, and project names, and adjusts the CI tests-studio workflow to use the correct environment variable for namespace. Class diagram for reserved character changes in Dataset, Namespace, and ProjectclassDiagram
class Dataset {
+DATASET_NAME_RESERVED_CHARS = [".", "@"]
+DATASET_NAME_REPLACEMENT_CHAR = "_"
}
class Namespace {
+NAMESPACE_NAME_RESERVED_CHARS = [".", "@"]
}
class Project {
+PROJECT_NAME_RESERVED_CHARS = [".", "@"]
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Deploying datachain-documentation with
|
| Latest commit: |
acd27c4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8008966f.datachain-documentation.pages.dev |
| Branch Preview URL: | https://ilongin-11817-change-default.datachain-documentation.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1196 +/- ##
=======================================
Coverage 88.72% 88.72%
=======================================
Files 152 152
Lines 13575 13575
Branches 1889 1889
=======================================
Hits 12044 12044
Misses 1088 1088
Partials 443 443
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
shcheklein
reviewed
Jul 2, 2025
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ilongin - I've reviewed your changes - here's some feedback:
- Add unit tests to verify that names containing '@' now correctly trigger validation errors for datasets, namespaces, and projects.
- Consider centralizing the reserved-character lists into a shared constant or utility to avoid duplication across dataset, namespace, and project modules.
- Double-check handling or migration strategy for any existing resources with '@' in their names, as this change tightens name validation and may be breaking.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Add unit tests to verify that names containing '@' now correctly trigger validation errors for datasets, namespaces, and projects.
- Consider centralizing the reserved-character lists into a shared constant or utility to avoid duplication across dataset, namespace, and project modules.
- Double-check handling or migration strategy for any existing resources with '@' in their names, as this change tightens name validation and may be breaking.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
shcheklein
reviewed
Jul 4, 2025
| @@ -6,7 +6,7 @@ | |||
| from datachain.error import InvalidNamespaceNameError | |||
|
|
|||
| N = TypeVar("N", bound="Namespace") | |||
| NAMESPACE_NAME_RESERVED_CHARS = ["."] | |||
| NAMESPACE_NAME_RESERVED_CHARS = [".", "@"] | |||
There was a problem hiding this comment.
just to make sure - are those replaced / escaped automatically if username contains them? do we check it when we create the default namespace from the username?
There was a problem hiding this comment.
They are replaced automatically for default namespace and validated when creating random namespace (error is thrown if name contains some of those)
shcheklein
approved these changes
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
@to reserved chars and fixing studio tests due to Studio companion PR changes: https://github.com/iterative/studio/pull/11823Summary by Sourcery
Add '@' to reserved characters for dataset, namespace, and project names, and update the CI workflow variable to fix Studio tests.
Enhancements:
CI: