-
Notifications
You must be signed in to change notification settings - Fork 115
Remove DATACHAIN_METASTORE_ARG_USERNAME
from tests-studio.yml
#1203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR removes a hard-coded DATACHAIN_METASTORE_ARG_USERNAME environment variable from the GitHub Actions tests-studio.yml workflow run command, streamlining the CI configuration by relying on default or external credentials. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Deploying datachain-documentation with
|
Latest commit: |
8aa14f0
|
Status: | ✅ Deploy successful! |
Preview URL: | https://465db56a.datachain-documentation.pages.dev |
Branch Preview URL: | https://datachain-server-env-test.datachain-documentation.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1203 +/- ##
==========================================
+ Coverage 88.70% 88.72% +0.02%
==========================================
Files 152 152
Lines 13577 13577
Branches 1890 1890
==========================================
+ Hits 12043 12046 +3
+ Misses 1090 1088 -2
+ Partials 444 443 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @0x2b3bfa0 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@ilongin, if you agree, please merge https://github.com/iterative/studio/pull/11846 and then #1203 (this) |
Summary by Sourcery
CI:
DATACHAIN_METASTORE_ARG_USERNAME=john
from thetests-studio.yml
job configuration