Skip to content

Remove DATACHAIN_METASTORE_ARG_USERNAME from tests-studio.yml #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2025

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Jul 5, 2025

Summary by Sourcery

CI:

  • Remove DATACHAIN_METASTORE_ARG_USERNAME=john from the tests-studio.yml job configuration

Copy link
Contributor

sourcery-ai bot commented Jul 5, 2025

Reviewer's Guide

This PR removes a hard-coded DATACHAIN_METASTORE_ARG_USERNAME environment variable from the GitHub Actions tests-studio.yml workflow run command, streamlining the CI configuration by relying on default or external credentials.

File-Level Changes

Change Details Files
Removed hard-coded DATACHAIN_METASTORE_ARG_USERNAME env var from the CI workflow
  • Deleted the DATACHAIN_METASTORE_ARG_USERNAME=john assignment from the run: command
.github/workflows/tests-studio.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8aa14f0
Status: ✅  Deploy successful!
Preview URL: https://465db56a.datachain-documentation.pages.dev
Branch Preview URL: https://datachain-server-env-test.datachain-documentation.pages.dev

View logs

Copy link

codecov bot commented Jul 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.72%. Comparing base (17060db) to head (8aa14f0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1203      +/-   ##
==========================================
+ Coverage   88.70%   88.72%   +0.02%     
==========================================
  Files         152      152              
  Lines       13577    13577              
  Branches     1890     1890              
==========================================
+ Hits        12043    12046       +3     
+ Misses       1090     1088       -2     
+ Partials      444      443       -1     
Flag Coverage Δ
datachain 88.65% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0x2b3bfa0 0x2b3bfa0 requested a review from a team July 6, 2025 01:49
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review July 6, 2025 01:49
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @0x2b3bfa0 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@0x2b3bfa0
Copy link
Member Author

@ilongin, if you agree, please merge https://github.com/iterative/studio/pull/11846 and then #1203 (this)

@0x2b3bfa0 0x2b3bfa0 merged commit 7bc1614 into main Jul 6, 2025
35 of 41 checks passed
@0x2b3bfa0 0x2b3bfa0 deleted the datachain-server-env-test branch July 6, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants