Skip to content

feat: add semantic timeline column classes#844

Open
johnyoonh wants to merge 1 commit intoivan-lednev:mainfrom
johnyoonh:feature/timeline-column-classes
Open

feat: add semantic timeline column classes#844
johnyoonh wants to merge 1 commit intoivan-lednev:mainfrom
johnyoonh:feature/timeline-column-classes

Conversation

@johnyoonh
Copy link
Copy Markdown

Summary

  • Allow the reusable timeline Column component to receive class names.
  • Add semantic planner-left-column and planner-right-column classes to the existing planner and time tracker timeline columns.

Test plan

  • ReadLints reports no diagnostics for changed files in Cursor.
  • npm run typescript could not complete in this checkout because dependencies are not installed (@tsconfig/svelte and Svelte type definitions missing).

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the reusable timeline Column component accept caller-provided CSS classes, then uses that capability to add semantic classes to the planner and time tracker timeline columns.

Changes:

  • Add support for passing class into Column and merging it with the base "column" class.
  • Add planner-left-column and planner-right-column classes to the two Column instances in timeline.svelte.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/ui/components/timeline.svelte Adds semantic class attributes to the planner/time-tracker columns for easier targeting/styling.
src/ui/components/column.svelte Introduces a class prop (aliased via className) and merges it into the root element’s class list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants