feat: split remote calendar events into a separate column#845
Open
johnyoonh wants to merge 2 commits intoivan-lednev:mainfrom
Open
feat: split remote calendar events into a separate column#845johnyoonh wants to merge 2 commits intoivan-lednev:mainfrom
johnyoonh wants to merge 2 commits intoivan-lednev:mainfrom
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Pull request overview
Adds an optional UI mode that renders timed remote calendar events in their own timeline column (separate from local planner tasks) and keeps multi-day header/all-day alignment correct when the extra column is enabled.
Changes:
- Adds a new setting to enable/disable rendering remote timed events in a separate timeline column.
- Splits timed tasks into “planner” vs “remote calendar” sets before horizontal overlap placement.
- Updates multi-day grid internal column counting to account for the optional extra remote-calendar column.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ui/settings-tab.ts | Adds a settings toggle for the new separate-column behavior. |
| src/settings.ts | Persists the new boolean setting and defaults it to false. |
| src/ui/hooks/use-edit/use-edit-context.ts | Splits timed tasks and applies overlap placement independently per column. |
| src/ui/components/timeline.svelte | Renders a second planner-related column for remote timed events when enabled. |
| src/ui/components/multi-day/multi-day-grid.svelte | Adjusts internal column counting so header/all-day rows remain aligned. |
| src/ui/components/column.svelte | Adds support for passing a class attribute into the reusable Column component. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| {#if settingsSignal.current.showRemoteCalendarEventsInSeparateColumn} | ||
| <Column | ||
| class="planner-right-column" |
Comment on lines
5
to
+6
| export let visibleHours: number[]; | ||
| let className: string | string[] = ""; |
Comment on lines
+192
to
+204
| const uniqueWithTime = uniqBy(t.getRenderKey)( | ||
| tasksForDay.withTime, | ||
| ) as Array<WithTime<Task>>; | ||
| const separateRemoteCalendars = | ||
| $settings.showRemoteCalendarEventsInSeparateColumn; | ||
| const remoteCalendarWithTime = separateRemoteCalendars | ||
| ? addHorizontalPlacing(uniqueWithTime.filter(isRemote)) | ||
| : []; | ||
| const plannerWithTime = separateRemoteCalendars | ||
| ? uniqueWithTime.filter((task) => !isRemote(task)) | ||
| : uniqueWithTime; | ||
| const withTime: Array<WithPlacing<WithTime<Task>>> = | ||
| addHorizontalPlacing(plannerWithTime); |
Comment on lines
+195
to
+210
| const separateRemoteCalendars = | ||
| $settings.showRemoteCalendarEventsInSeparateColumn; | ||
| const remoteCalendarWithTime = separateRemoteCalendars | ||
| ? addHorizontalPlacing(uniqueWithTime.filter(isRemote)) | ||
| : []; | ||
| const plannerWithTime = separateRemoteCalendars | ||
| ? uniqueWithTime.filter((task) => !isRemote(task)) | ||
| : uniqueWithTime; | ||
| const withTime: Array<WithPlacing<WithTime<Task>>> = | ||
| addHorizontalPlacing(plannerWithTime); | ||
|
|
||
| return { | ||
| ...tasksForDay, | ||
| withTime, | ||
| remoteCalendarWithTime, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
planner-left-columnandplanner-right-columnclasses used here.Test plan
npm run typescriptcould not complete in this checkout because dependencies are not installed (@tsconfig/svelteand Svelte type definitions missing).Made with Cursor