Skip to content

fix(ci): Stabilize CodeQL check results#8614

Closed
jkowall wants to merge 1 commit into
mainfrom
codex/fix-codeql-alerts
Closed

fix(ci): Stabilize CodeQL check results#8614
jkowall wants to merge 1 commit into
mainfrom
codex/fix-codeql-alerts

Conversation

@jkowall

@jkowall jkowall commented May 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • set an explicit CodeQL analysis category so reusable workflow uploads match the configuration names GitHub sees on main
  • avoid preallocating Badger trace ID results with the request-derived search limit that CodeQL flagged as an uncontrolled allocation size

Root cause

The CodeQL workflow is invoked through the CI orchestrator, so GitHub generated PR analysis categories from .github/workflows/ci-orchestrator.yml while the baseline configurations on main were recorded under .github/workflows/codeql.yml. That produced the "configurations not found" warning even though the Go and Python CodeQL jobs completed successfully.

The same PR check also surfaced a high CodeQL alert in Badger storage because filterIDs used plan.limit, derived from query input, as the slice capacity.

Validation

  • make fmt
  • make lint
  • make test

Signed-off-by: Jonah Kowall <jkowall@kowall.net>
@jkowall jkowall added the changelog:ci Change related to continuous integration / testing label May 22, 2026
@jkowall jkowall marked this pull request as ready for review May 22, 2026 11:52
@jkowall jkowall requested a review from a team as a code owner May 22, 2026 11:52
Copilot AI review requested due to automatic review settings May 22, 2026 11:52
@jkowall

jkowall commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favor of #8615, which is sourced from the jkowall/jaeger-F fork branch.

@jkowall jkowall closed this May 22, 2026
@codecov

codecov Bot commented May 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.59%. Comparing base (393f160) to head (cb9b542).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8614      +/-   ##
==========================================
+ Coverage   96.56%   96.59%   +0.02%     
==========================================
  Files         331      331              
  Lines       17566    17566              
==========================================
+ Hits        16963    16967       +4     
+ Misses        454      451       -3     
+ Partials      149      148       -1     
Flag Coverage Δ
badger_direct 8.94% <100.00%> (ø)
badger_e2e 1.04% <0.00%> (ø)
cassandra-4.x-direct-manual 14.55% <0.00%> (ø)
cassandra-4.x-e2e-auto 1.03% <0.00%> (ø)
cassandra-4.x-e2e-manual 1.03% <0.00%> (ø)
cassandra-5.x-direct-manual 14.55% <0.00%> (ø)
cassandra-5.x-e2e-auto 1.03% <0.00%> (ø)
cassandra-5.x-e2e-manual 1.03% <0.00%> (ø)
clickhouse-direct 8.97% <0.00%> (ø)
clickhouse-e2e 1.16% <0.00%> (ø)
elasticsearch-6.x-direct 16.87% <0.00%> (ø)
elasticsearch-7.x-direct 16.91% <0.00%> (ø)
elasticsearch-8.x-direct 17.05% <0.00%> (ø)
elasticsearch-8.x-e2e 1.09% <0.00%> (+0.04%) ⬆️
elasticsearch-9.x-e2e 1.04% <0.00%> (ø)
grpc_direct 7.90% <0.00%> (ø)
grpc_e2e 1.04% <0.00%> (ø)
kafka-3.x-v2 1.04% <0.00%> (ø)
memory_v2 1.04% <0.00%> (ø)
opensearch-1.x-direct 16.95% <0.00%> (ø)
opensearch-2.x-direct 16.95% <0.00%> (ø)
opensearch-2.x-e2e 1.04% <0.00%> (ø)
opensearch-3.x-e2e 1.04% <0.00%> (ø)
query 1.04% <0.00%> (ø)
tailsampling-processor 0.55% <0.00%> (ø)
unittests 94.89% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jkowall jkowall removed the request for review from Copilot May 22, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/storage changelog:ci Change related to continuous integration / testing security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant