fix(ci): Stabilize CodeQL check results#8615
Conversation
Signed-off-by: Jonah Kowall <jkowall@kowall.net>
There was a problem hiding this comment.
Pull request overview
This PR stabilizes CodeQL check results in CI by making the analysis category deterministic across reusable workflow invocations, and addresses a CodeQL finding in Badger trace ID filtering by avoiding preallocation based on request-derived limits.
Changes:
- Add an explicit CodeQL
categoryso uploaded SARIF results match the baseline configuration names onmain. - Remove request-derived slice preallocation in Badger trace ID filtering to avoid an “uncontrolled allocation size” CodeQL alert.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
internal/storage/v1/badger/spanstore/reader.go |
Avoids preallocating a result slice capacity from plan.limit when filtering trace IDs. |
.github/workflows/codeql.yml |
Sets an explicit CodeQL analysis category to stabilize configuration naming across workflow contexts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| traces := make([]model.TraceID, 0) | ||
|
|
CI Summary ReportMetrics ComparisonView changed metricsFor label-level diff details, open the CI run and expand the "Compare metrics and generate summary" step logs. metrics_snapshot_elasticsearch_8.x_e2e — ⬇️ download diff
Code Coverage✅ Coverage 97.3% (baseline 97.3%) ➡️ View CI run | View publish logs |
Signed-off-by: Victor Chidera Obiezue <obiezuechidera@gmail.com>
Summary
mainRoot cause
The CodeQL workflow is invoked through the CI orchestrator, so GitHub generated PR analysis categories from
.github/workflows/ci-orchestrator.ymlwhile the baseline configurations onmainwere recorded under.github/workflows/codeql.yml. That produced the "configurations not found" warning even though the Go and Python CodeQL jobs completed successfully.The same PR check also surfaced a high CodeQL alert in Badger storage because
filterIDsusedplan.limit, derived from query input, as the slice capacity.Validation
make fmtmake lintmake test