Skip to content

fix(ci): Stabilize CodeQL check results#8615

Merged
yurishkuro merged 1 commit into
jaegertracing:mainfrom
jkowall:codex/fix-codeql-alerts
May 24, 2026
Merged

fix(ci): Stabilize CodeQL check results#8615
yurishkuro merged 1 commit into
jaegertracing:mainfrom
jkowall:codex/fix-codeql-alerts

Conversation

@jkowall

@jkowall jkowall commented May 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • set an explicit CodeQL analysis category so reusable workflow uploads match the configuration names GitHub sees on main
  • avoid preallocating Badger trace ID results with the request-derived search limit that CodeQL flagged as an uncontrolled allocation size

Root cause

The CodeQL workflow is invoked through the CI orchestrator, so GitHub generated PR analysis categories from .github/workflows/ci-orchestrator.yml while the baseline configurations on main were recorded under .github/workflows/codeql.yml. That produced the "configurations not found" warning even though the Go and Python CodeQL jobs completed successfully.

The same PR check also surfaced a high CodeQL alert in Badger storage because filterIDs used plan.limit, derived from query input, as the slice capacity.

Validation

  • make fmt
  • make lint
  • make test

Signed-off-by: Jonah Kowall <jkowall@kowall.net>
@jkowall jkowall added the changelog:ci Change related to continuous integration / testing label May 22, 2026
@jkowall jkowall marked this pull request as ready for review May 22, 2026 11:53
@jkowall jkowall requested a review from a team as a code owner May 22, 2026 11:53
Copilot AI review requested due to automatic review settings May 22, 2026 11:53
@dosubot dosubot Bot added security storage/badger Issues related to badger storage labels May 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR stabilizes CodeQL check results in CI by making the analysis category deterministic across reusable workflow invocations, and addresses a CodeQL finding in Badger trace ID filtering by avoiding preallocation based on request-derived limits.

Changes:

  • Add an explicit CodeQL category so uploaded SARIF results match the baseline configuration names on main.
  • Remove request-derived slice preallocation in Badger trace ID filtering to avoid an “uncontrolled allocation size” CodeQL alert.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
internal/storage/v1/badger/spanstore/reader.go Avoids preallocating a result slice capacity from plan.limit when filtering trace IDs.
.github/workflows/codeql.yml Sets an explicit CodeQL analysis category to stabilize configuration naming across workflow contexts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +339 to 340
traces := make([]model.TraceID, 0)

@github-actions

Copy link
Copy Markdown

CI Summary Report

Metrics Comparison

⚠️ 36 metric change(s) detected (informational)

View changed metrics

For label-level diff details, open the CI run and expand the "Compare metrics and generate summary" step logs.

metrics_snapshot_elasticsearch_8.x_e2e⬇️ download diff
3 added

  • jaeger_storage_latency
  • jaeger_storage_requests
  • rpc_server_call_duration

Code Coverage

✅ Coverage 97.3% (baseline 97.3%)

➡️ View CI run | View publish logs
2026-05-22 12:17:50 UTC

@yurishkuro yurishkuro merged commit 8466d65 into jaegertracing:main May 24, 2026
144 of 147 checks passed
@jkowall jkowall deleted the codex/fix-codeql-alerts branch May 26, 2026 01:06
vic-comm pushed a commit to vic-comm/jaeger that referenced this pull request Jun 11, 2026
Signed-off-by: Victor Chidera Obiezue <obiezuechidera@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:ci Change related to continuous integration / testing security storage/badger Issues related to badger storage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants