Add dharanikesav developer for plugin-throttle-concurrents.yml#4121
Closed
dharanikesav wants to merge 1 commit intojenkins-infra:masterfrom
Closed
Add dharanikesav developer for plugin-throttle-concurrents.yml#4121dharanikesav wants to merge 1 commit intojenkins-infra:masterfrom
dharanikesav wants to merge 1 commit intojenkins-infra:masterfrom
Conversation
Contributor
|
I'd like to see some more thorough real-life testing as described in jenkinsci/throttle-concurrent-builds-plugin#269 (review) to ensure that this won't have a negative impact on existing Jenkins controllers. |
Author
|
Hi @basil , I have resolved your comments and tested the change locally and created a new PR: jenkinsci/throttle-concurrent-builds-plugin#272 Thanks, |
Contributor
|
This should be fixed in https://github.com/jenkinsci/throttle-concurrent-builds-plugin/releases/tag/throttle-concurrents-2.15, so can this PR be closed? |
Author
|
@basil Yes, this PR can be closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@basil , please approve
Link to GitHub repository
When modifying release permission
List the GitHub usernames of the users who should have commit permissions below:
@username1@username2This is needed in order to cut releases of the plugin or component.
If you are modifying the release permission of your plugin or component, fill out the following checklist:
When enabling automated releases (cd: true)
Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.
Link to the PR enabling CD in your plugin
There are IRC Bot commands for it.