Skip to content

Add dharanikesav developer for plugin-throttle-concurrents.yml#4121

Closed
dharanikesav wants to merge 1 commit intojenkins-infra:masterfrom
dharanikesav:master
Closed

Add dharanikesav developer for plugin-throttle-concurrents.yml#4121
dharanikesav wants to merge 1 commit intojenkins-infra:masterfrom
dharanikesav:master

Conversation

@dharanikesav
Copy link
Copy Markdown

@dharanikesav dharanikesav commented Oct 9, 2024

@basil , please approve

Link to GitHub repository

When modifying release permission

List the GitHub usernames of the users who should have commit permissions below:

  • @username1
  • @username2

This is needed in order to cut releases of the plugin or component.

If you are modifying the release permission of your plugin or component, fill out the following checklist:

### Release permission checklist (for submitters)
- [x] The usernames of the users added to the "developers" section in the .yml file are the same the users use to log in to [accounts.jenkins.io](https://accounts.jenkins.io/).
- [x] All users added have logged in to [Artifactory](https://repo.jenkins-ci.org/) and [Jira](https://issues.jenkins.io/) once.
- [x] I have mentioned an [existing team member](https://github.com/orgs/jenkinsci/teams) of the plugin or component team to approve this request.

When enabling automated releases (cd: true)

Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.

Link to the PR enabling CD in your plugin

### CD checklist (for submitters)
- [ ] I have provided a link to the pull request in my plugin, which enables CD according to the documentation. 
### Reviewer checklist
- [ ] Check that the `$pluginId Developers` team has `Admin` permissions while granting the access.
- [ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
- [ ] If security contacts are changed (this includes add/remove), ping the security officer (currently `@Wadeck`) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it.

@dharanikesav dharanikesav requested a review from a team as a code owner October 9, 2024 10:43
@dharanikesav dharanikesav changed the title Update developers for plugin-throttle-concurrents.yml Add dharanikesav developer for plugin-throttle-concurrents.yml Oct 9, 2024
@basil
Copy link
Copy Markdown
Contributor

basil commented Oct 9, 2024

I'd like to see some more thorough real-life testing as described in jenkinsci/throttle-concurrent-builds-plugin#269 (review) to ensure that this won't have a negative impact on existing Jenkins controllers.

@dharanikesav
Copy link
Copy Markdown
Author

Hi @basil ,

I have resolved your comments and tested the change locally and created a new PR: jenkinsci/throttle-concurrent-builds-plugin#272

Thanks,
Dharani

@basil
Copy link
Copy Markdown
Contributor

basil commented Oct 9, 2024

@dharanikesav
Copy link
Copy Markdown
Author

@basil Yes, this PR can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants