Skip to content

fix:improve concurrency restriction#272

Closed
dharanikesav wants to merge 4 commits intojenkinsci:masterfrom
dharanikesav:master
Closed

fix:improve concurrency restriction#272
dharanikesav wants to merge 4 commits intojenkinsci:masterfrom
dharanikesav:master

Conversation

@dharanikesav
Copy link
Copy Markdown

@dharanikesav dharanikesav commented Oct 9, 2024

We have jenkins WorkFlowJobs that does not run on any specific nodes. When we run those pipelines, "Prevent multiple jobs with identical parameters from running concurrently" option is not working properly. To handle this scenario, have updated the logic to check ongoing builds based on runs in addition to nodes -> executors.

This change is critical for us.

Testing done
Manual testing done locally for following test cases:

  • Check if concurrency works when no parameters defined
  • Check if concurrency works when parameters defined but throttle build not configured to be restricted based on parameters
  • Check if concurrency work as expected when restricted based on parameters

cc: @basil

@basil
Copy link
Copy Markdown
Member

basil commented Oct 9, 2024

Is this problem not solved by #232?

@dharanikesav
Copy link
Copy Markdown
Author

Hi @basil ,

Sorry, i have not noticed the other PR. Yes, the issue is resolved now.

Thanks,
Dharani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants