Merged
Conversation
A new folder parameter has been added for templates and clone/deploy actions. This parameter creates the new VM in the specified folder of vSphere (which can be a path of folders or a unique name folder). If left blank or folder not available, it will create the VM in the same folder as the original VM. It is specially interesting for organizing and separating templates from autodeployed slaves. For example, we have daily backups and we want separate folders for templates and autodeployed dynamic slaves, so we can specify to backup only the folders that contain the templates and omit folders that contain the dynamic slaves.
|
I just give a try to your PR and works perfect! |
Member
|
@maleix @jswager src/main/resources/org/jenkinsci/plugins/vsphere/builders/Clone/config.jelly looks incorrect. Also, src/main/resources/org/jenkinsci/plugins/vsphere/builders/Deploy/config.jelly specifies field="Folder" instead of "folder" (that'll probably work, but it's not pretty). (Apologies for the delay in noticing this; it's been 6 months since I last followed this plugin but I'm catching up now) |
Member
|
I've raised #72 as a prospective fix for these issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new folder parameter has been added for templates and clone/deploy
actions.
This parameter creates the new VM in the specified folder of vSphere
(which can be a path of folders or a unique name folder).
If left blank or folder not available, it will create the VM in the same
folder as the original VM.
It is specially interesting for organizing and separating templates from
autodeployed slaves.
For example, we have daily backups and we want separate folders for
templates and autodeployed dynamic slaves, so we can specify to backup
only the folders that contain the templates and omit folders that
contain the dynamic slaves.