Skip to content

Correct field names in the Jelly code for Folder parameter.#72

Merged
pjdarton merged 1 commit intojenkinsci:masterfrom
pjdarton:fix_folder_jelly
Jul 28, 2017
Merged

Correct field names in the Jelly code for Folder parameter.#72
pjdarton merged 1 commit intojenkinsci:masterfrom
pjdarton:fix_folder_jelly

Conversation

@pjdarton
Copy link
Copy Markdown
Member

@pjdarton pjdarton commented Jun 8, 2017

Affects Clone and Deploy build steps.

This addresses the concerns raised in #61 (comment)

@pjdarton pjdarton mentioned this pull request Jun 8, 2017
@pjdarton
Copy link
Copy Markdown
Member Author

pjdarton commented Jun 9, 2017

This is partially duplicated by #66
That PR is just the bugfix; this one is the bugfix and a cosmetic case-change.
We probably only need one of them merged.

@phoewass
Copy link
Copy Markdown

phoewass commented Jul 6, 2017

Could you please merge this PR as this bug is blocking us ?

@pjdarton
Copy link
Copy Markdown
Member Author

pjdarton commented Jul 6, 2017

At present, all merges are a bit blocked - the only person with write-access is Jason (jswager), he's largely unavailable, and neither I or Eric (elordahl) have the access required to perform merges. Jason did (briefly) reappear to say that he no longer has the necessary resources to build/test this plugin anymore and is looking for volunteers to take it over.
Personally, I'm willing to drive one release (so that my changes, which includes this one, are "in"), but I can't promise much more than that...

In the meantime, you could always go to the "Show all checks" link, drill down to the Jenkins build that tested this PR and download the .hpi file that it created from https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fvsphere-cloud-plugin/detail/PR-72/1/artifacts
I accept that it would be better to have an official release with these changes, and I'm hopeful we'll come to an arrangement whereby we can do that, but if you're blocked by this, then you do always have the option of using a non-official release (install from the "advanced -> upload" section of the Jenkins plugin page) to unblock you until we've got a proper release.

@pjdarton pjdarton merged commit e454667 into jenkinsci:master Jul 28, 2017
@pjdarton pjdarton deleted the fix_folder_jelly branch July 28, 2017 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants