[Docs]: jest30 testRegex, testPathPatterns breaking

[sibelius]

Page(s)

I'm trying to migrate from jest29 to jest30 but my regex is breaking

testRegex: '(/__tests__/.*|(\\.|/)(test|spec))\\.(j|t)s?sx?$',

how to debug?

where in the jest codebase I can see the final glob pattern generated?

Description

Trying to migrate, but regex pattern is breaking

[sibelius]

I've tried the default one

testRegex: '(/__tests__/.*|(\\\\.|/)(test|spec))\\\\.[mc]?[jt]sx?$',

but it is not finding any files either

this is a testpath

packages/service-login/src/components/login/tests/Login.spec.tsx

we are using a monorepo and using jest multiproject config

module.exports = {
  projects: [
    ...getProjects(),
    '<rootDir>/packages/woovi-electron/jest.main.config.js',
    '<rootDir>/packages/woovi-electron/jest.renderer.config.js',
  ],
}

[sibelius]

does it use glob or micromatch?

https://github.com/micromatch/micromatch

https://github.com/isaacs/node-glob

[MillerSvt]

We do not convert regexp to glob.

You can debug here:

const regexToMatcher = (testRegex: Config.ProjectConfig['testRegex']) => {
  const regexes = testRegex.map(testRegex => new RegExp(testRegex));

  return (path: string) =>
    regexes.some(regex => {
      const result = regex.test(path);

      // prevent stateful regexes from breaking, just in case
      regex.lastIndex = 0;

      return result;
    });
};

[sibelius]

the problem is in the testPathPatterns

'/root/app/packages/service-login/src/components/login/userMaster/__tests__/UserMasterCompaniesLogin.spec.tsx': 'testPathPatterns',

how testPathPatterns is calculated ?

here is the full config

{
  "configs": [
  {
    "automock": false,
    "cache": true,
    "cacheDirectory": "/root/app/packages/service-login/.jest-cache",
    "clearMocks": true,
    "collectCoverageFrom": [],
    "coverageDirectory": "/root/app/packages/service-login/coverage",
    "coveragePathIgnorePatterns": [
      "/node_modules/"
    ],
    "coverageReporters": [
      "json",
      "text",
      "lcov",
      "clover"
    ],
    "cwd": "/root/app",
    "detectLeaks": false,
    "detectOpenHandles": false,
    "displayName": {
      "color": "white",
      "name": "@woovi/service-login"
    },
    "errorOnDeprecated": false,
    "extensionsToTreatAsEsm": [],
    "fakeTimers": {
      "enableGlobally": false
    },
    "forceCoverageMatch": [],
    "globals": {},
    "haste": {
      "computeSha1": false,
      "enableSymlinks": false,
      "forceNodeFilesystemAPI": true,
      "throwOnModuleCollision": false
    },
    "id": "5f7ffabd96f022fed02f46c79324df3a",
    "injectGlobals": true,
    "moduleDirectories": [
      "node_modules",
      "src"
    ],
    "moduleFileExtensions": [
      "js",
      "css",
      "ts",
      "tsx",
      "json"
    ],
    "moduleNameMapper": [
      [
        "\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$",
        "/root/app/packages/testutils/test/fileMock.tsx"
      ],
      [
        "\\.(css|less)$",
        "identity-obj-proxy"
      ],
      [
        "^.+\\.(md|mdx)$",
        "jest-transformer-mdx"
      ],
      [
        "@woovi/node-printer",
        "/root/app/packages/testutils/test/fileMock.tsx"
      ],
      [
        "^@woovi/roles$",
        "/root/app/packages/roles/src/Roles.ts"
      ],
      [
        "^@woovi/flags$",
        "/root/app/packages/flags/src/index.ts"
      ],
      [
        "^@woovi/email$",
        "/root/app/packages/email/src/index.tsx"
      ]
    ],
    "modulePathIgnorePatterns": [],
    "openHandlesTimeout": 1000,
    "prettierPath": "prettier",
    "resetMocks": false,
    "resetModules": false,
    "restoreMocks": false,
    "rootDir": "/root/app/packages/service-login",
    "roots": [
      "/root/app/packages/service-login"
    ],
    "runner": "/root/app/node_modules/jest-runner/build/index.js",
    "sandboxInjectedGlobals": [],
    "setupFiles": [
      "/root/app/packages/testutils/test/setupFiles.js"
    ],
    "setupFilesAfterEnv": [
      "/root/app/packages/testutils/test/setupFilesAfterEnv.js"
    ],
    "skipFilter": false,
    "slowTestThreshold": 5,
    "snapshotFormat": {
      "escapeString": false,
      "printBasicPrototype": false
    },
    "snapshotSerializers": [],
    "testEnvironment": "/root/app/node_modules/jest-environment-jsdom/build/index.js",
    "testEnvironmentOptions": {},
    "testLocationInResults": false,
    "testMatch": [],
    "testPathIgnorePatterns": [
      "/node_modules/",
      "/__generated__/",
      "/build/",
      "/dist/",
      "/scripts/"
    ],
    "testRegex": [
      "__tests__/.*\\.(spec|test)\\.tsx?$"
    ],
    "testRunner": "/root/app/node_modules/jest-config/node_modules/jest-circus/build/runner.js",
    "transform": [
      [
        "^.+\\.(js|ts|tsx)?$",
        "/root/app/node_modules/@swc/jest/index.js",
        {
          "sourceMaps": true,
          "jsc": {
            "parser": {
              "syntax": "typescript",
              "tsx": true
            },
            "transform": {
              "react": {
                "runtime": "automatic"
              }
            },
            "experimental": {
              "plugins": [
                [
                  "@swc/plugin-relay",
                  {
                    "rootDir": "/root/app/packages/testutils",
                    "language": "typescript"
                  }
                ]
              ]
            }
          }
        }
      ],
      [
        "^.+\\.(md|mdx)$",
        "/root/app/node_modules/jest-transformer-mdx/index.js",
        {}
      ]
    ],
    "transformIgnorePatterns": [
      "node_modules/(?!use-debounce|uuid|firebase|@firebase|d3-interpolate|d3-color|d3-scale|d3-array|internmap|d3-format|d3-time|d3-shape|d3-path|d3-delaunay|delaunator|robust-predicates|query-string|react-hotkeys-hook)"
    ],
    "waitNextEventLoopTurnForUnhandledRejectionEvents": false,
    "watchPathIgnorePatterns": []
  }
],
  "globalConfig": {
  "bail": 0,
    "changedFilesWithAncestor": false,
    "ci": false,
    "collectCoverage": false,
    "collectCoverageFrom": [],
    "coverageDirectory": "/root/app/coverage",
    "coverageProvider": "v8",
    "coverageReporters": [
    "lcov",
    "html"
  ],
    "detectLeaks": false,
    "detectOpenHandles": false,
    "errorOnDeprecated": false,
    "expand": false,
    "findRelatedTests": false,
    "forceExit": false,
    "json": false,
    "lastCommit": false,
    "listTests": false,
    "logHeapUsage": false,
    "maxConcurrency": 5,
    "maxWorkers": 11,
    "noStackTrace": false,
    "nonFlagArgs": [
    "./packages/service-login"
  ],
    "notify": false,
    "notifyMode": "failure-change",
    "onlyChanged": false,
    "onlyFailures": false,
    "openHandlesTimeout": 1000,
    "passWithNoTests": false,
    "projects": [
    "packages/service-login/jest.config.js"
  ],
    "reporters": [
    [
      "default",
      {}
    ],
    [
      "/root/app/node_modules/jest-junit/index.js",
      {}
    ]
  ],
    "rootDir": "/root/app",
    "runInBand": false,
    "runTestsByPath": false,
    "seed": 1316024779,
    "skipFilter": false,
    "snapshotFormat": {
    "escapeString": false,
      "printBasicPrototype": false
  },
  "testFailureExitCode": 1,
    "testPathPatterns": [
    "./packages/service-login"
  ],
    "testSequencer": "/root/app/node_modules/@jest/test-sequencer/build/index.js",
    "updateSnapshot": "new",
    "useStderr": false,
    "waitNextEventLoopTurnForUnhandledRejectionEvents": false,
    "watch": false,
    "watchAll": false,
    "watchman": true,
    "workerThreads": false
},
  "version": "30.0.0-beta.3"
}

[sibelius]

the problem is here in a monorepo

jest/packages/jest-pattern/src/TestPathPatterns.ts

Line 115 in 7998905

if (this.toRegex(regexStr).test(pathToTest)) {

it is checking this regex /^packages\/service-login/i against the relative path like this src/components/login/userMaster/__tests__/UserMasterPasswordLogin.spec.tsx

instead of /root/app/packages/service-login/src/components/login/userMaster/__tests__/UserMasterPasswordLogin.spec.tsx

[lencioni]

Not sure if this is related (let me know and I can open a new issue) but I also noticed that testPathPatterns seems to not work when used in a jest config file. CLI is okay though. Here's a repro repo: https://github.com/lencioni/jest-test-path-patterns

[sibelius]

it does work when using the cli

but the problem is that my jest.config.js does not have any testPathPatterns at all

jest is autogenerating it for each package of my monorepo

this is the same behavior as jest29, but jest29 works

[sibelius]

my fix for jest pattern for now

diff --git a/build/index.js b/build/index.js
index 346f316b42d9e91394c824e5ec48699c27d6838e..8d87eac7d6209c41429ed19e023814fcf17d5d8f 100644
--- a/build/index.js
+++ b/build/index.js
@@ -140,6 +140,10 @@ class TestPathPatternsExecutor {
       if (this.toRegex(regexStr).test(pathToTest)) {
         return true;
       }
+
+      if (this.toRegex(regexStr).test(absPath)) {
+        return true;
+      }
     }
     return false;
   }

[cpojer]

@sibelius would you be able to send a PR with a test?

[sibelius]

I will give it a try with my patch from above

[gustav0d]

my fix for jest pattern for now

diff --git a/build/index.js b/build/index.js
index 346f316b42d9e91394c824e5ec48699c27d6838e..8d87eac7d6209c41429ed19e023814fcf17d5d8f 100644
--- a/build/index.js
+++ b/build/index.js
@@ -140,6 +140,10 @@ class TestPathPatternsExecutor {
       if (this.toRegex(regexStr).test(pathToTest)) {
         return true;
       }
+
+      if (this.toRegex(regexStr).test(absPath)) {
+        return true;
+      }
     }
     return false;
   }

this fix breaks returns true only if matches relative path

should the test change to allow it? since it gets the home from the /home