Fixed: Global options not respected in relationship links rendering #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurei
approved these changes
Feb 7, 2021
|
Let's not merge this yet, I should add some tests first. |
|
It was assigned to me, was that on purpose, or did you mean to request a review? |
|
Not on purpose, I intended to ask for review. |
…en when explicitly turned off in global options (and not configured on the relationship itself).
bart-degreed
force-pushed
the
relationship-links-fix
branch
from
21e8842 to
eec96a7
Compare
…n value setters because this is a flags enum, so the checks were incorrect. For example, you are not allowed to pass `Links.Paging`, but are allowed to pass `Links.Related | Links.Paging` or `Links.All`, which all mean "include paging in the set of links".
|
@maurei Added tests, can you please take another look? |
maurei
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: relationship links were rendered for ToMany relationships, even when explicitly turned off in global options (and not configured on the relationship itself).
Fixes #945.