-
Notifications
You must be signed in to change notification settings - Fork 645
Added UMD wrapper for bootstrap-decorator #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added UMD wrapper for bootstrap-decorator #495
Conversation
This reverts commit 9f27842.
Interesting, I just made this PR: :-) |
I realized that this is way better than my PR, as it should require() everything properly. |
While going on with packaging and modules, I should mention that I just added ASF and some of the most used(?) ASF add-ons to the jspm registry: (BTW, this PR will render the 0.8.4 main-override of ASF unnecessary) |
@angelaharalson awesome! I don't use RequireJS so I really appreciate help with this. Can I trouble you to redo the PR without the minified files in |
@angelaharalson I merged it manually since I want to migrate the decorator to it's own repo. Thanks! |
Hi, this seems to be a problem with PR, I am however not sure what is the correct solution. This PR sets it to "schemaForm" for all situations, which does not work with those kinds of frameworks. To make the add-on I am maintaining, angular-schema-form-dynamic-select work with my "MBE-frontend" which uses SystemJS/JSPM and the names are automagically generated, I have to set the amd and cjs options for the require-section. This way, loading bootstrap-decorator.js correctly causes angular-schema-form.js to load. However, I am not completely sure about all of this, UMD and ES6 modules and their naming conventions and when what is used is a bit hard to understand and not always clear. So if someone more knowledgeable than me could chime in here would be great. |
@angelaharalson, @davidlgj : I feel pretty sure that the correct solution is: dependencies: function() {
return [
{name: 'schemaForm',
amd:"angular-schema-form",
cjs: 'angular-schema-form'},
]; |
Aaand now something seems to be strange in gulp-umd. I created an issue there, I'll be back. |
Fixes this issue:
RequireJs wrapper for bootstrap-decorator #435