More hostname label separator tests #776
Conversation
|
A lot of these fail in my implementation (they show as valid where the test says it's invalid), but that likely just means I need to mark these as TODO, due to a gap in the library I'm using. |
|
Looking at the IDNA specifications some more, it's unclear if the extended set of label separators is included in RFC 5890. The only reference I can find is in an appendix of RFC 5891 ("Summary of Major Changes from IDNA2003" (RFC 3490)):
Not sure what that means. They're in RFC 3490 (as noted in #760), but I don't know how relevant that is since JSON schema uses 5890 for They're also included in Unicode technical standard 46, which references both IDNA versions. 🤷 Leading/trailing separators are similarly confusing. |
jdesrosiers
left a comment
jdesrosiers
left a comment
There was a problem hiding this comment.
I've been looking into IDN validation requirements myself recently and I came across this PR. I'm sure I saw it before, wasn't in a place to understand it at the time.
Good call on adding tests for empty labels. That's definitely a gap we want to fill.
I hadn't noticed that the separator tests reference the wrong specification. I'm not sure either if the extended set of separators applies to IDNA2008. I'm ok with leaving them there and even adding to them until we can find some confirmation that it's not correct. It appears to be correct according to UTS #46 which is what most implementations are probably using anyway.
| { | ||
| "description": "dot separator with label that is too long when separator is respected", | ||
| "data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα.com", | ||
| "valid": false | ||
| }, |
There was a problem hiding this comment.
I don't think these tests have anything to do with separators. If the label is too long, it's going to fail regardless of the separator. I think these just amount to duplicates of label length tests that we already have.
These are mostly meant to test that the additional `idn-hostname` label separators are treated like `.` and are only allowed between labels.
Regular `hostname` should not support the extended label separators used in `idn-hostname`.
This tests that the extended label separators used in `idn-hostname` properly validate individual labels and don't treat the whole instance as a single label.
jdesrosiers
force-pushed
the
idn-hostname-separators
branch
from
bef99a3 to
ef212f5
Compare
jdesrosiers
force-pushed
the
idn-hostname-separators
branch
from
ef212f5 to
aab0875
Compare
3 participants
My implementation doesn't yet support all
idn-hostnamelabel separators properly, but (for multiple reasons) it is still passing the tests added here: #760These are the tests I came up with while fixing/reproducing the issues.