Skip to content

Clarify trailing slash ref-resolution weirdness #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2018

Conversation

handrews
Copy link
Contributor

Addresses #559 (paging @mokkabonna)

There is no way to do RFC 3986 reference resolution that just
removes a trailing slash without duplicating things. Every
option is confusing and weird, but avoiding trailing slashes
is increasingly common.

Let's just face that and explain that it's weird and this is
the best that can be done.

@@ -2051,7 +2057,7 @@ Link: <https://api.example.com/trees/1/nodes/456>; rev="up"
<![CDATA[{
"$id": "https://schema.example.com/thing-collection",
"$schema": "http://json-schema.org/draft-08/hyper-schema#",
"base": "https://api.example.com/",
"base": "https://example.com/api/",
"type": "object",
"required": ["elements"],
"properties": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the other instance of a trailing slash, you added a note stating that it was included intentionally to show its confusing nature. Is this one also intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was for the "href": "../api" line, not the base. I'll try to make that more clear.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregsdennis reworked it with more detail, see if that makes sense now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So base URIs require trailing slashes so that relative URIs can be resolved against them. Is there any concern about attempting to resolve one relative URI against another?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is all RFC 3986 stuff, nothing is required. But OpenAPI and other systems have, very annoyingly, messed up their concept of a base URI so that it is concatenation instead of reference resolution, and if you do that with reference resolution nothing will work right. You can go look at OpenAPI if you want to dig into it.

This is why I hate writing examples. How much of RFC 3986 do I need to explain here? That is not a rhetorical question. Something needs to be explained because popular formats have done it wrong, but I do not want to put a whole URI reference resolution tutorial here. It's an incredibly complicated process if you go into all of it, but in practice it's mostly pretty straightforward except for the slash thing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not...

👍

There is no way to do RFC 3986 reference resolution that just
removes a trailing slash without duplicating things.  Every
option is confusing and weird, but avoiding trailing slashes
is increasingly common.

Let's just face that and explain that it's weird and this is
the best that can be done.
@handrews handrews merged commit 7d0daba into json-schema-org:master Nov 21, 2018
@handrews handrews deleted the trailing-slash branch November 27, 2018 20:25
@gregsdennis gregsdennis added clarification Items that need to be clarified in the specification and removed Type: Bug labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Items that need to be clarified in the specification Priority: Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants