Use ECOS 1.0.3 + Add setup function that takes keyword arguments #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is looking good, thanks for the PR! I still do not have a decent test suite but my idea is to update the test script to compare the results with the I'll test this on OS X and Linux and merge ASAP. |
jfsantos
added a commit
that referenced
this pull request
Jun 7, 2014
Use ECOS 1.0.3 + Add setup function that takes keyword arguments
|
Merged, thanks and sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't really made pull requests in the past, so apologies if this isn't the right etiquette.
Two main changes:
nothingin case there are no conic inequalities etc.In terms of testing, CVX.jl is currently using my fork of ECOS.jl and seems to be working fine: https://github.com/karanveerm/CVX.jl/blob/master/src/solvers/ecos.jl. Let me know if you'd like any changes/ have any problems. Thanks!