-
Notifications
You must be signed in to change notification settings - Fork 5
👣 Add example footer #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this looks good to me - I haven't been able to test it locally yet though. But if you two think the functionality is there, here are a few minor suggestions and I'm happy to merge this whenever so that we can add docs
footer.md
Outdated
@@ -0,0 +1,54 @@ | |||
% Here we're using `grid` to imply grid semantics -- the actual | |||
% formatting (including columns) is handled by CSS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend adding a URL that has a link back to the docs for people that land here and want to learn more (maybe the section navigation page?)
footer.md
Outdated
- [About](https://mystmd.org/overview/ecosystem) | ||
- [Guide](https://mystmd.org/guide) | ||
- [Sandbox](https://mystmd.org/sandbox) | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra whitespace (sorry on mobile right now otherwise I'd fix it)
myst.yml
Outdated
@@ -5,10 +5,30 @@ project: | |||
title: Hello Landing Pages | |||
toc: | |||
- file: index.md | |||
- title: Text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's with all these? Intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a chance to look locally, I think it is really nice! I added some brief explanatory text so that it's easier to understand.
IMO it's safe to merge now and is a nice improvement, so I'll do so. @stefanv when you do the docs, it'd be helpful to have bi-directional links with this one and the docs so that users could land on either and discover the other.
Hey, thanks for the edits, Chris! 🙏 |
No description provided.