Reintroduce selection container's set_title/get_title methods #3471
Milestone
Comments
|
+1 but maybe with a deprecation warning? (I forget how noisy deprecation warnings are these days...) |
|
I don't see a point in doing a deprecation warning - I'm happy to support those two convenience functions going forward, as they don't hurt us and make it possible for the existing base to just keep using the code. In other words, I don't plan to remove them once we've reintroduced them. |
jasongrout
added a commit
to jasongrout/ipywidgets
that referenced
this issue
Jun 7, 2022
Also, we eagerly compute a title list that updates when the children are updated, so that .titles is always reasonable. Fixes jupyter-widgets#3471.
jasongrout
added a commit
to jasongrout/ipywidgets
that referenced
this issue
Jun 7, 2022
Also, we eagerly compute a title list that updates when the children are updated, so that .titles is always reasonable. Fixes jupyter-widgets#3471.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A conversation with @michaelp-db about stability of APIs inspired me to reconsider the
set_title/get_titlemethod deletion done in 91ba29d (#2746). It doesn't hurt us to have the set_title/get_title as convenience functions still, and will be one less problem for people to fix in moving to ipywidgets 8, so I'm in favor of adding back in the methods to preserve compatibility with 7.x code.The text was updated successfully, but these errors were encountered: