Add back set_title and get_title to selection containers #3477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Also, we eagerly compute a title list that updates when the children are updated, so that .titles is always reasonable. Fixes jupyter-widgets#3471.
This is a breaking change from get_title/set_title in ipywidgets 7.
… compatibility with 7.x
ibdafna
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back set_title and get_title to selection containers
Also, we eagerly compute a title list that updates when the children are updated, so that
.titlesis always reasonable.This does change the api slightly from 7.x: a title is not allowed to be None, but instead should be an empty string.
In order to better preserve the 7.x api, I also make it so that if you do
set_title(index, None), it actually sets the title to''. However, if you doget_title(index), it won't return None then, so that is a small breakage from the 7.x api.Fixes #3471.