Fix for #7565 to move add cell button to the inner notebook area#7720
Open
Oakwhisper wants to merge 4 commits intojupyter:mainfrom
Open
Fix for #7565 to move add cell button to the inner notebook area#7720Oakwhisper wants to merge 4 commits intojupyter:mainfrom
Oakwhisper wants to merge 4 commits intojupyter:mainfrom
Conversation
Contributor
|
|
Author
|
bot please update playwright snapshots |
Author
|
Looks like I don't have permissions to update the snapshots. I also need a label applied to this PR. I believe "enhancement" would be appropriate |
|
bot please update playwright snapshots |
KH-Coder865
suggested changes
Jan 15, 2026
Contributor
KH-Coder865
left a comment
KH-Coder865
left a comment
There was a problem hiding this comment.
I think after removing these empty CSS blocks of code, everything looks fine.
Comment on lines
139
to
140
| body[data-notebook='notebooks'] .jp-Notebook-footer { | ||
| background: unset; | ||
| width: 100%; | ||
| margin-left: unset; | ||
| } |
Contributor
There was a problem hiding this comment.
It would be great if these empty CSS blocks could be deleted for the sake of better maintainability.
Comment on lines
156
to
158
| body[data-notebook='notebooks'] .jp-WindowedPanel-viewport { | ||
| background: var(--jp-layout-color0); | ||
| box-shadow: var(--jp-elevation-z4); | ||
|
|
||
| /* Extra padding at the top and bottom so the notebook looks nicer */ | ||
| padding-top: calc(2 * var(--jp-notebook-padding)); | ||
| padding-bottom: calc(2 * var(--jp-notebook-padding)); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In both desktop and mobile the add cell button design did not match JupyterLab's design for the add a cell button. This change adjusts the CSS to bring the button into the inner notebook area to harmonize the designs.
Addresses #7565
Original Mobile (on hover):
Original Desktop (on hover):
Modified Mobile (on hover):
Modified Desktop (on hover):
Button is not visible when not hovering:
