-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Fix for #7565 to move add cell button to the inner notebook area #7720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Oakwhisper
wants to merge
4
commits into
jupyter:main
Choose a base branch
from
Oakwhisper:#7565
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c2346a8
Adjusted css so the 'Click to add a cell' button is included on the w…
Oakwhisper 3fc2ce8
Removed unnecessary calculation
Oakwhisper e5e8514
Update Playwright Snapshots
github-actions[bot] 66e0287
Update Playwright Snapshots
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,22 +33,37 @@ body[data-notebook='notebooks'] .jp-NotebookPanel-toolbar { | |
| padding-right: calc(calc(100% - var(--jp-notebook-max-width)) * 0.5); | ||
| } | ||
|
|
||
| body[data-notebook='notebooks'] .jp-WindowedPanel-outer { | ||
| width: unset !important; | ||
| padding-top: unset; | ||
| body[data-notebook='notebooks'] .jp-WindowedPanel { | ||
| background: var(--jp-layout-color2); | ||
| padding-left: calc(calc(100% - var(--jp-notebook-max-width)) * 0.5); | ||
| padding-right: calc( | ||
| calc( | ||
| 100% - var(--jp-notebook-max-width) - var(--jp-notebook-padding-offset) | ||
| ) * 0.5 | ||
| 100% - var(--jp-notebook-max-width) - var(--jp-notebook-padding-offset) | ||
| ) * 0.5 | ||
| ) !important; | ||
| background: var(--jp-layout-color2); | ||
| padding-top: var(--jp-notebook-padding-offset); | ||
| height: 100%; | ||
| overflow-y: auto; | ||
|
|
||
| } | ||
|
|
||
| body[data-notebook='notebooks'] .jp-WindowedPanel-outer { | ||
| width: unset !important; | ||
| height: fit-content; | ||
|
|
||
|
|
||
| background: var(--jp-layout-color0); | ||
| box-shadow: var(--jp-elevation-z4); | ||
|
|
||
| /* Extra padding at the top and bottom so the notebook looks nicer */ | ||
| padding-top: calc(2 * var(--jp-notebook-padding)); | ||
| padding-bottom: calc(2 * var(--jp-notebook-padding)); | ||
| } | ||
|
|
||
| body[data-notebook='notebooks'] .jp-WindowedPanel-inner { | ||
| margin-top: var(--jp-notebook-toolbar-margin-bottom); | ||
| /* Adjustments for the extra top and bottom notebook padding */ | ||
| margin-bottom: calc(4 * var(--jp-notebook-padding)); | ||
| margin-bottom: calc(1.5 * var(--jp-notebook-padding)); | ||
| } | ||
|
|
||
| body[data-notebook='notebooks'] .jp-Notebook-cell { | ||
|
|
@@ -57,8 +72,7 @@ body[data-notebook='notebooks'] .jp-Notebook-cell { | |
|
|
||
| /* Empty space at the bottom of the notebook (similar to classic) */ | ||
| body[data-notebook='notebooks'] | ||
| .jp-Notebook.jp-mod-scrollPastEnd | ||
| .jp-WindowedPanel-outer::after { | ||
| .jp-Notebook.jp-mod-scrollPastEnd { | ||
| min-height: 100px; | ||
| } | ||
|
|
||
|
|
@@ -112,13 +126,17 @@ body[data-notebook='notebooks'] | |
| body[data-notebook='notebooks'] .jp-RawCell .jp-cell-toolbar { | ||
| top: calc(0.5 * var(--jp-notebook-padding)); | ||
| } | ||
|
|
||
| body[data-notebook='notebooks'] .jp-Notebook-footer { | ||
| width: calc(100vw - 43px); | ||
| margin-left: 28px; | ||
| margin-right: 15px; | ||
| margin-top: 10px; | ||
| } | ||
| } | ||
|
|
||
| /* Tweak the notebook footer (to add a new cell) */ | ||
| body[data-notebook='notebooks'] .jp-Notebook-footer { | ||
| background: unset; | ||
| width: 100%; | ||
| margin-left: unset; | ||
| } | ||
|
|
||
| /* Mobile View */ | ||
|
|
@@ -136,12 +154,7 @@ body[data-format='mobile'] .jp-ToolbarButton .jp-DebuggerBugButton { | |
| } | ||
|
|
||
| body[data-notebook='notebooks'] .jp-WindowedPanel-viewport { | ||
| background: var(--jp-layout-color0); | ||
| box-shadow: var(--jp-elevation-z4); | ||
|
|
||
| /* Extra padding at the top and bottom so the notebook looks nicer */ | ||
| padding-top: calc(2 * var(--jp-notebook-padding)); | ||
| padding-bottom: calc(2 * var(--jp-notebook-padding)); | ||
| } | ||
|
Comment on lines
156
to
158
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similarly here. |
||
|
|
||
| /* Notebook box shadow */ | ||
|
|
||
Binary file modified
BIN
-5.38 KB
(80%)
ui-tests/test/general.spec.ts-snapshots/notebook-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+334 Bytes
(100%)
ui-tests/test/general.spec.ts-snapshots/notebook-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.72 KB
(74%)
ui-tests/test/mobile.spec.ts-snapshots/notebook-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+123 Bytes
(100%)
ui-tests/test/mobile.spec.ts-snapshots/notebook-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.63 KB
(82%)
ui-tests/test/notebook.spec.ts-snapshots/notebook-full-width-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.07 KB
(100%)
ui-tests/test/notebook.spec.ts-snapshots/notebook-full-width-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if these empty CSS blocks could be deleted for the sake of better maintainability.