Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 30 additions & 17 deletions packages/notebook-extension/style/base.css
Original file line number Diff line number Diff line change
Expand Up @@ -33,22 +33,37 @@ body[data-notebook='notebooks'] .jp-NotebookPanel-toolbar {
padding-right: calc(calc(100% - var(--jp-notebook-max-width)) * 0.5);
}

body[data-notebook='notebooks'] .jp-WindowedPanel-outer {
width: unset !important;
padding-top: unset;
body[data-notebook='notebooks'] .jp-WindowedPanel {
background: var(--jp-layout-color2);
padding-left: calc(calc(100% - var(--jp-notebook-max-width)) * 0.5);
padding-right: calc(
calc(
100% - var(--jp-notebook-max-width) - var(--jp-notebook-padding-offset)
) * 0.5
100% - var(--jp-notebook-max-width) - var(--jp-notebook-padding-offset)
) * 0.5
) !important;
background: var(--jp-layout-color2);
padding-top: var(--jp-notebook-padding-offset);
height: 100%;
overflow-y: auto;

}

body[data-notebook='notebooks'] .jp-WindowedPanel-outer {
width: unset !important;
height: fit-content;


background: var(--jp-layout-color0);
box-shadow: var(--jp-elevation-z4);

/* Extra padding at the top and bottom so the notebook looks nicer */
padding-top: calc(2 * var(--jp-notebook-padding));
padding-bottom: calc(2 * var(--jp-notebook-padding));
}

body[data-notebook='notebooks'] .jp-WindowedPanel-inner {
margin-top: var(--jp-notebook-toolbar-margin-bottom);
/* Adjustments for the extra top and bottom notebook padding */
margin-bottom: calc(4 * var(--jp-notebook-padding));
margin-bottom: calc(1.5 * var(--jp-notebook-padding));
}

body[data-notebook='notebooks'] .jp-Notebook-cell {
Expand All @@ -57,8 +72,7 @@ body[data-notebook='notebooks'] .jp-Notebook-cell {

/* Empty space at the bottom of the notebook (similar to classic) */
body[data-notebook='notebooks']
.jp-Notebook.jp-mod-scrollPastEnd
.jp-WindowedPanel-outer::after {
.jp-Notebook.jp-mod-scrollPastEnd {
min-height: 100px;
}

Expand Down Expand Up @@ -112,13 +126,17 @@ body[data-notebook='notebooks']
body[data-notebook='notebooks'] .jp-RawCell .jp-cell-toolbar {
top: calc(0.5 * var(--jp-notebook-padding));
}

body[data-notebook='notebooks'] .jp-Notebook-footer {
width: calc(100vw - 43px);
margin-left: 28px;
margin-right: 15px;
margin-top: 10px;
}
}

/* Tweak the notebook footer (to add a new cell) */
body[data-notebook='notebooks'] .jp-Notebook-footer {
background: unset;
width: 100%;
margin-left: unset;
}
Comment on lines 139 to 140
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if these empty CSS blocks could be deleted for the sake of better maintainability.


/* Mobile View */
Expand All @@ -136,12 +154,7 @@ body[data-format='mobile'] .jp-ToolbarButton .jp-DebuggerBugButton {
}

body[data-notebook='notebooks'] .jp-WindowedPanel-viewport {
background: var(--jp-layout-color0);
box-shadow: var(--jp-elevation-z4);

/* Extra padding at the top and bottom so the notebook looks nicer */
padding-top: calc(2 * var(--jp-notebook-padding));
padding-bottom: calc(2 * var(--jp-notebook-padding));
}
Comment on lines 156 to 158
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here.


/* Notebook box shadow */
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ui-tests/test/general.spec.ts-snapshots/notebook-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ui-tests/test/mobile.spec.ts-snapshots/notebook-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.