feat(gRPC): build gRPC client interface to initiate communication with recovery-decider service #8178

AdityaKumaar21 · 2025-05-29T10:34:56Z

Type of Change

Description

I have implemented a gRPC client that facilitates communication with the recovery-decider gRPC service. The client should be capable of initializing and managing the connection to the service, sending requests, and handling responses in accordance with the defined service contract (protobuf definitions).

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Decider gRPC server:-

Decider gRPC client(HS):-

Predictor gRPC server:-

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

Summary by CodeRabbit

New Features
- Introduced support for a gRPC client: Recovery Decider, enabling external retry decisioning.
- Integrated dynamic scheduling for smart retry logic based on external gRPC service responses.
- Added new protobuf definition for Recovery Decider.
Improvements
- Enhanced revenue recovery payment flow with richer payment intent context and smarter retry scheduling.
- Expanded logging and API flow tracking with new flow types.
Configuration
- Added configuration options for new gRPC clients in the development environment.
Bug Fixes
- Improved error handling and logging for gRPC client interactions.

…tion_monitoring_feilds

…n_monitoring

config/deployments/env_specific.toml

crates/external_services/Cargo.toml

crates/external_services/build.rs

crates/router/src/workflows/revenue_recovery.rs

config/development.toml

crates/router/src/workflows/revenue_recovery.rs

config/config.example.toml

config/deployments/env_specific.toml

config/development.toml

crates/external_services/src/grpc_client.rs

crates/external_services/src/lib.rs

SanchithHegde · 2025-08-05T10:26:21Z

crates/router/src/workflows/revenue_recovery.rs

+        logger::debug!(
+            payment_intent_id = ?payment_intent.get_id(),
+            attempt_id = ?payment_attempt.get_id(),
+            message = "payment_attempt.payment_method_data is None"
+        );


Nit: You don't have to explicitly pass the message field.

Suggested change

logger::debug!(

payment_intent_id = ?payment_intent.get_id(),

attempt_id = ?payment_attempt.get_id(),

message = "payment_attempt.payment_method_data is None"

);

logger::debug!(

payment_intent_id = ?payment_intent.get_id(),

attempt_id = ?payment_attempt.get_id(),

"payment_attempt.payment_method_data is None"

);

SanchithHegde · 2025-08-05T10:30:28Z

crates/router/src/workflows/revenue_recovery.rs

+
+    let card_network_str = billing_connector_payment_method_details
+        .and_then(|details| match details {
+            BillingConnectorPaymentMethodDetails::Card(card_info) => card_info.card_network.clone(),


Nit: Can't we avoid the clone here? I think you should be able to, by deriving Copy on the common_enums::enums::CardNetwork enum.

SanchithHegde · 2025-08-05T10:31:04Z

crates/router/src/workflows/revenue_recovery.rs

+            BillingConnectorPaymentMethodDetails::Card(card_info) => card_info.card_issuer.clone(),
+        })?;
+
+    let card_funding_str = payment_intent


Card funding? Where are we obtaining this information from?

This is basically card type that we are fetching from payment intent's PaymentRevenueRecoveryMetadata-> payment_method_subtype

Why the "funding" in the variable name?

crates/router/src/workflows/revenue_recovery.rs

SanchithHegde · 2025-08-05T10:40:51Z

crates/router/src/workflows/revenue_recovery.rs

+    fn from(internal_request: InternalDeciderRequest) -> Self {
+        Self {
+            first_error_message: internal_request.first_error_message,
+            billing_state: internal_request.billing_state.peek().to_string(),


@Aprabhat19 @srujanchikke Ideally you folks should consider using an equivalent of Secret on the gRPC server side as well, similar to how the connector-service folks are doing...

…old to 60s in every config

SanchithHegde · 2025-08-06T08:32:09Z

config/config.example.toml

 [billing_connectors_invoice_sync]
 billing_connectors_which_requires_invoice_sync_call = "recurly" # List of billing connectors which has invoice sync api call

 [revenue_recovery]
-monitoring_threshold_in_seconds = 2592000 # 30*24*60*60 secs , threshold for monitoring the retry system
-retry_algorithm_type = "cascading" # type of retry algorithm
+monitoring_threshold_in_seconds = 60  # 30*24*60*60 secs , threshold for monitoring the retry system


The number and the comment don't match?

SanchithHegde · 2025-08-06T08:32:46Z

config/config.example.toml

 [billing_connectors_invoice_sync]
 billing_connectors_which_requires_invoice_sync_call = "recurly" # List of billing connectors which has invoice sync api call

 [revenue_recovery]
-monitoring_threshold_in_seconds = 2592000 # 30*24*60*60 secs , threshold for monitoring the retry system
-retry_algorithm_type = "cascading" # type of retry algorithm
+monitoring_threshold_in_seconds = 60  # 30*24*60*60 secs , threshold for monitoring the retry system


The number (60) and the comment don't match?

SanchithHegde · 2025-08-06T08:39:57Z

crates/external_services/src/grpc_client.rs

+                        );
+
+                    logger::info!("Recovery Decider gRPC client successfully initialized");
+                    // Some(Box::new(client) as Box<dyn RecoveryDeciderClientInterface>)


Remove commented code.

SanchithHegde · 2025-08-06T08:43:28Z

crates/router/src/core/revenue_recovery/types.rs

@@ -97,7 +99,7 @@ impl RevenueRecoveryPaymentsAttemptStatus {
        payment_intent: &PaymentIntent,
        process_tracker: storage::ProcessTracker,
        revenue_recovery_payment_data: &storage::revenue_recovery::RevenueRecoveryPaymentData,
-        payment_attempt: payment_attempt::PaymentAttempt,
+        payment_attempt: PaymentAttempt,


Nit: Can't we accept a reference here? Do you necessarily need an owned value?

SanchithHegde · 2025-08-06T08:43:56Z

crates/router/src/core/revenue_recovery/types.rs

        process: &storage::ProcessTracker,
-        payment_attempt: payment_attempt::PaymentAttempt,
+        payment_attempt: PaymentAttempt,


Same here, can't we accept a reference?

SanchithHegde · 2025-08-06T08:46:14Z

crates/router/src/types/storage/revenue_recovery.rs

+
+#[derive(Debug, serde::Deserialize, Clone)]
+pub struct RecoveryTimestamp {
+    pub initial_timestamp_in_hours: i64,


Why do we need an i64, can't we use something like u16 or u32? This is anyway a duration, we don't need these to be negative.

SanchithHegde · 2025-08-06T08:46:28Z

crates/router/src/types/storage/revenue_recovery.rs

            }
        }
    }
 }
+
 #[derive(Debug, serde::Deserialize, Clone, Default)]
 pub struct RevenueRecoverySettings {
    pub monitoring_threshold_in_seconds: i64,


Same here, we don't need an i64?

hrithikesh026

Core changes LGTM

…ordea-sepa * 'main' of github.com:juspay/hyperswitch: fix(router): [worldpayvantiv] dispute validations and statuses (#8862) chore(version): 2025.08.07.0 feat(connector): [WORLDPAYVANTIV] Populate Network Decline Error Code & Message (#8856) feat(router): add support for partial authorization (#8833) feat(gRPC): build gRPC client interface to initiate communication with recovery-decider service (#8178) fix(connector): [CYBERSOURCE] fix response field for netcetera authentication response (#8850) chore(events): making events nanosecond level precision (#8759)

Nishanth Challa and others added 30 commits April 2, 2025 14:06

add address field and attempt_count in stripebilling webhook

809da65

Merge branch 'main' into stripebilling_transaction_monitoring_feilds

8f160b0

add endtime and start time of invoice in webhook

bd411f5

ran formatter

2e02b84

add full address with encryption

fd47398

consumes required fields to support transaction monitoring[chargebee]

4a82642

formats the code

dd531f9

Merge branch 'main' into support_for_storing_address

01d98a0

docs(openapi): re-generate OpenAPI specification

653cd5d

addresses clippy v2 failure

6cae8e1

chore: run formatter

787912a

makes billing address optional

a5c5d9a

Merge branch 'main' into stripebilling_transaction_monitoring_feilds

da18869

Merge branch 'support_for_storing_address' into stripebilling_transac…

f5d5294

…tion_monitoring_feilds

adds get_billing_address_for_invoice function

826202a

invoice from webhook for stripebilling

d03c564

add bool to get invoice from webhook or additional call

24dac12

adds billing connector invoice sync flow

a4262c7

typo fix

71ec2bc

add invoice sync flow to revenue recovery

3b04911

chore: run formatter

44e5a18

adds config to fetch details

75ef438

recurly invoice sync connector inetgration support

c53b310

add invoice sync call support in recovery incoming file

0479693

Merge branch 'main' into recurly_invoice_sync_support_with_transactio…

4227dfb

…n_monitoring

recoveryincoming changes

69d5d24

define ve type and change connector integration v1 to v2

6764550

resolve clippy fails

2fe86f9

add support for transaction monitoring for recurly

3142502

Merge branch 'main' into billing_connector_invoice_psync_call

49f7a22

AdityaKumaar21 added 2 commits August 4, 2025 12:53

Update build.rs

e810940

Update Cargo.toml

baee0b3

SanchithHegde reviewed Aug 4, 2025

View reviewed changes

AdityaKumaar21 and others added 5 commits August 4, 2025 18:43

resolving comments

99daa29

addressing comments

560a72b

fix clippy

7bd8144

chore: run formatter

45435cc

fix clippy

59f5a77

AdityaKumaar21 requested review from a team August 5, 2025 06:37

SanchithHegde reviewed Aug 5, 2025

View reviewed changes

AdityaKumaar21 and others added 3 commits August 5, 2025 16:21

Merge branch 'main' into build-grpc-client-recovery

bdddba9

adding more field in decider request and update the monitoring thresh…

4e19f8f

…old to 60s in every config

formatting

d973789

SanchithHegde reviewed Aug 6, 2025

View reviewed changes

AdityaKumaar21 and others added 3 commits August 6, 2025 16:01

adding more fields in decider request

bbdc2a6

Merge branch 'main' into build-grpc-client-recovery

c9031ce

chore: run formatter

ee1735d

AdityaKumaar21 linked an issue Aug 6, 2025 that may be closed by this pull request

Refactor(recovery-gRPC):- refactor Decider-client gRPC #8853

Open

AdityaKumaar21 mentioned this pull request Aug 6, 2025

Refactor(recovery-gRPC):- refactor Decider-client gRPC #8853

Open

AdityaKumaar21 removed a link to an issue Aug 6, 2025

Refactor(recovery-gRPC):- refactor Decider-client gRPC #8853

Open

SanchithHegde approved these changes Aug 6, 2025

View reviewed changes

srujanchikke approved these changes Aug 6, 2025

View reviewed changes

hrithikesh026 approved these changes Aug 6, 2025

View reviewed changes

likhinbopanna added this pull request to the merge queue Aug 6, 2025

Merged via the queue into main with commit 654c15e Aug 6, 2025
18 of 22 checks passed

likhinbopanna deleted the build-grpc-client-recovery branch August 6, 2025 13:44

hyperswitch-bot bot removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Aug 10, 2025

feat(gRPC): build gRPC client interface to initiate communication with recovery-decider service #8178

feat(gRPC): build gRPC client interface to initiate communication with recovery-decider service #8178

Uh oh!

Conversation

AdityaKumaar21 commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

Summary by CodeRabbit

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hrithikesh026 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AdityaKumaar21 commented May 29, 2025 •

edited

Loading