Skip to content

fix(connector): [NETCETERA] fix response field for netcetera authentication response #8850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025

Conversation

dgeee13
Copy link
Contributor

@dgeee13 dgeee13 commented Aug 6, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Currently we are not recieving field three_ds_requestor_challenge_ind in Netcetera's authentication response since the struct is incorrectly declared in the transformers file.

  1. three_ds_requestor_challenge_ind is currently a part of NetceteraAuthenticationSuccessResponse enum, but it should be a field inside authenitcation_request
  2. three_ds_requestor_challenge_ind has type optional string currently, but it should be a vector of string (ref documentation - https://3dss.netcetera.com/3dsserver/doc/2.5.2.1/3ds-authentication)

Current structure

NetceteraAuthenticationSuccessResponse{
....
three_ds_requestor_challenge_ind: Option<String>
...}

Correct structure

NetceteraAuthenticationSuccessResponse{
....
authentication_request: {
three_ds_requestor_challenge_ind: Option<Vector<String>>,
}
...}

This PR introduces the above fix in the struct.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested netcetera's challenge via local hyperswitch sdk.
As expected, we are now able to get three_ds_requestor_challenge_ind field in the NetceteraAuthenticationSuccessResponse.

Screenshot 2025-08-06 at 4 29 03 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

…hallenge_ind for netcetera authentication response
@dgeee13 dgeee13 requested a review from a team as a code owner August 6, 2025 10:59
Copy link

semanticdiff-com bot commented Aug 6, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/hyperswitch_connectors/src/connectors/netcetera/transformers.rs  0% smaller

@dgeee13 dgeee13 self-assigned this Aug 6, 2025
@likhinbopanna likhinbopanna added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit 30b4522 Aug 6, 2025
23 of 29 checks passed
@likhinbopanna likhinbopanna deleted the cybersource3dsauth branch August 6, 2025 13:40
pixincreate added a commit that referenced this pull request Aug 7, 2025
…ordea-sepa

* 'main' of github.com:juspay/hyperswitch:
  fix(router): [worldpayvantiv] dispute validations and statuses (#8862)
  chore(version): 2025.08.07.0
  feat(connector): [WORLDPAYVANTIV] Populate Network Decline Error Code & Message (#8856)
  feat(router): add support for partial authorization (#8833)
  feat(gRPC): build gRPC client interface to initiate communication with recovery-decider service (#8178)
  fix(connector): [CYBERSOURCE] fix response field for netcetera authentication response (#8850)
  chore(events): making events nanosecond level precision (#8759)
@dgeee13 dgeee13 changed the title fix(connector): [CYBERSOURCE] fix response field for netcetera authentication response fix(connector): [NETCETERA] fix response field for netcetera authentication response Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] (connector): [Netcetera] Fix three_ds_requestor_challenge_ind field in Netcetera Response
4 participants