feat(connector): [Barclaycard] Add Google Pay Payment Method #8786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
2 tasks
deepanshu-iiitu
requested changes
Jul 30, 2025
| @@ -1003,19 +1003,30 @@ static BARCLAYCARD_SUPPORTED_PAYMENT_METHODS: LazyLock<SupportedPaymentMethods> | |||
| PaymentMethodDetails { | |||
| mandates: enums::FeatureStatus::NotSupported, | |||
| refunds: enums::FeatureStatus::Supported, | |||
| supported_capture_methods, | |||
| supported_capture_methods: supported_capture_methods.clone(), | |||
There was a problem hiding this comment.
Dashboard changes for google pay via barclays?
Comment on lines
193
to
221
| let addr = address_details | ||
| .and_then(|addr| addr.address.as_ref()) | ||
| .ok_or_else(|| errors::ConnectorError::MissingRequiredField { | ||
| field_name: "billing_address_details", | ||
| })?; | ||
|
|
||
| let administrative_area = addr.to_state_code_as_optional().unwrap_or_else(|_| { | ||
| addr.state | ||
| .clone() | ||
| .map(|state| Secret::new(format!("{:.20}", state.expose()))) | ||
| }); | ||
|
|
||
| let address1 = | ||
| addr.line1 | ||
| .clone() | ||
| .ok_or_else(|| errors::ConnectorError::MissingRequiredField { | ||
| field_name: "billing_address.line1", | ||
| })?; | ||
| let locality = | ||
| addr.city | ||
| .clone() | ||
| .ok_or_else(|| errors::ConnectorError::MissingRequiredField { | ||
| field_name: "billing_address.city", | ||
| })?; | ||
| let country = addr | ||
| .country | ||
| .ok_or_else(|| errors::ConnectorError::MissingRequiredField { | ||
| field_name: "billing_address.country", | ||
| })?; |
There was a problem hiding this comment.
Use utils here from crates/hyperswitch_connectors/src/utils.rs
deepanshu-iiitu
previously approved these changes
Jul 31, 2025
ShankarSinghC
previously approved these changes
Aug 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Anurag-05-prog
dismissed stale reviews from ShankarSinghC and deepanshu-iiitu
via
b1a5d58
ShankarSinghC
approved these changes
Aug 6, 2025
deepanshu-iiitu
approved these changes
Aug 6, 2025
pixincreate
added a commit
that referenced
this pull request
Aug 6, 2025
…ordea-sepa * 'main' of github.com:juspay/hyperswitch: (89 commits) feat(router): [worldpayvantiv] add dispute list sync and implement dispute (#8830) feat(core): Add support for Void after Capture (#8839) fix(wasm): [FISERV] Added GooglePay Payment Method Type (#8832) feat(connector): [Barclaycard] Add Google Pay Payment Method (#8786) chore(version): 2025.08.06.0 feat(core): Added additional authentication fields for 3ds external authentication (#8758) refactor(core): propagate network_transaction_id in response of payment (#8829) fix(core): add fix for stopping multiple event locking idempotent logs (#8034) feat(connector): [AUTHORIZEDOTNET] create connector customer flow added (#8774) feat(core): Add L2_L3 Data Support (#8828) feat(connector): [NMI] Add mandates flow (#8652) fix(connector): [Wise] send uuid as connector_transaction_id (#8836) feat(core): populate UCS status_code in response headers (#8788) feat(external_services): Fixed Url for Unified Connector Service gRPC Client (#8587) chore: reorder v2 migrations folders (#8671) fix(router): Take merchant ID from headers in API Key - Revoke (v2) (#8808) fix(connector): (payload) currency auth key wasm changes (#8825) feat(payment-methods): add filtering logic for payment method list v2 (#8606) feat(router): add support for apple pay pre-decrypted token in the payments confirm call (#8815) chore(version): 2025.08.05.0 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Closes this issue
Description
Added Google Pay Payment Method
Additional Changes
Motivation and Context
How did you test it?
Payments - Create:
Request:
Response:
Checklist
cargo +nightly fmt --allcargo clippy