Skip to content

fix(connector): (payload) currency auth key wasm changes #8825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2025

Conversation

pixincreate
Copy link
Member

@pixincreate pixincreate commented Aug 1, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • this commit introduced wasm changes for payload auth key to use currencyauthkey instead of headkerkey. payload is a special case where the currency is dependent on the processing_account_id. this was not done properly that resulted in wasm build to fail at run time.
  • this commit reverted the wasm changes which resulted in dashboard page for payload to break.
  • in this pr, we have reverted the revert pr and also introduced a new specific case for payload to support currency based auth.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

crates/connector_configs/toml/*.toml

Motivation and Context

my previous changes caused the wasm build to fail which i reverted earlier today as that the fastest fix. however, i need that to be fixed. so this pr.

closes #8610

How did you test it?

wasm build should succeed. in run time, wasm should not throw error, especially for cashtocode and payload, as shown below:

i constructed a simple html page to check this:

cashtocode payload
image imageimage

there exist some issue with data loading in the page, so i directly loaded the wasm and spit out the data:

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by just clippy && just clippy_v2
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@pixincreate pixincreate added this to the July 2025 Release milestone Aug 1, 2025
@pixincreate pixincreate self-assigned this Aug 1, 2025
@pixincreate pixincreate added the A-connector-integration Area: Connector integration label Aug 1, 2025
Copy link

semanticdiff-com bot commented Aug 1, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/connector_configs/src/connector.rs  25% smaller
  crates/connector_configs/toml/development.toml Unsupported file format
  crates/connector_configs/toml/production.toml Unsupported file format
  crates/connector_configs/toml/sandbox.toml Unsupported file format

@pixincreate pixincreate marked this pull request as ready for review August 1, 2025 17:54
@pixincreate pixincreate requested review from a team as code owners August 1, 2025 17:54
@pixincreate pixincreate added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Aug 1, 2025
JeevaRamu0104
JeevaRamu0104 previously approved these changes Aug 4, 2025
awasthi21
awasthi21 previously approved these changes Aug 4, 2025
@pixincreate pixincreate dismissed stale reviews from awasthi21 and JeevaRamu0104 via 9f725e3 August 4, 2025 07:51
@pixincreate pixincreate requested review from JeevaRamu0104 and awasthi21 and removed request for a team August 4, 2025 07:56
@likhinbopanna likhinbopanna added this pull request to the merge queue Aug 5, 2025
Merged via the queue into main with commit 4d4a81e Aug 5, 2025
22 of 26 checks passed
@likhinbopanna likhinbopanna deleted the connector/payload-wasm-changes branch August 5, 2025 08:19
@pixincreate pixincreate added C-bug Category: Bug and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 5, 2025
pixincreate added a commit that referenced this pull request Aug 6, 2025
…ordea-sepa

* 'main' of github.com:juspay/hyperswitch: (89 commits)
  feat(router): [worldpayvantiv] add dispute list sync and implement dispute (#8830)
  feat(core): Add support for Void after Capture (#8839)
  fix(wasm): [FISERV] Added GooglePay Payment Method Type (#8832)
  feat(connector): [Barclaycard] Add Google Pay Payment Method (#8786)
  chore(version): 2025.08.06.0
  feat(core): Added additional authentication fields for 3ds external authentication (#8758)
  refactor(core): propagate network_transaction_id in response of payment (#8829)
  fix(core): add fix for stopping multiple event locking idempotent logs (#8034)
  feat(connector): [AUTHORIZEDOTNET] create connector customer flow added (#8774)
  feat(core): Add L2_L3 Data Support  (#8828)
  feat(connector): [NMI] Add mandates flow (#8652)
  fix(connector): [Wise] send uuid as connector_transaction_id (#8836)
  feat(core): populate UCS status_code in response headers (#8788)
  feat(external_services): Fixed Url for Unified Connector Service gRPC Client (#8587)
  chore: reorder v2 migrations folders (#8671)
  fix(router): Take merchant ID from headers in API Key - Revoke (v2) (#8808)
  fix(connector): (payload) currency auth key wasm changes (#8825)
  feat(payment-methods): add filtering logic for payment method list v2 (#8606)
  feat(router): add support for apple pay pre-decrypted token in the payments confirm call (#8815)
  chore(version): 2025.08.05.0
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Add mandates for Payload
5 participants