Add base support for vec6#583
Merged
Merged
Conversation
GlenTiki
commented
Jun 23, 2019
| info[3]->ToNumber(Nan::GetCurrentContext()).ToLocalChecked()->Value(), | ||
| info[4]->ToNumber(Nan::GetCurrentContext()).ToLocalChecked()->Value(), | ||
| info[5]->ToNumber(Nan::GetCurrentContext()).ToLocalChecked()->Value() | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
I wanted to rewrite this using macros to minimise the duplication but I'm too unfamiliar in cpp land to do it correctly, so this is the alternative I came up with.
There was a problem hiding this comment.
No worries, no need to introduce macros here :)
Owner
Contributor
Author
|
Nice, feedback is incorporated now! :) While in there I noticed that Vec4's typing was wrong for the constructor, so I fixed it. |
Owner
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per issue #578 this library needs support for vec6. This is a PR to add that support.