Skip to content

Upgraded dependencies, dropped PHP < 7.3 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Ocramius
Copy link
Contributor

Fixes #64

@Ocramius Ocramius mentioned this pull request Jan 11, 2021
@Ocramius
Copy link
Contributor Author

Overall would endorse bumping dependency ranges. Also, travis-ci will probably hang forever here.

@WyriHaximus
Copy link
Collaborator

Overall would endorse bumping dependency ranges.

Going to update this, and several other external packages I maintain to include Dependabot and GitHub Actions this week.

Also, travis-ci will probably hang forever here.

Travis now fails because composer.lock seems out of date.

@Ocramius
Copy link
Contributor Author

Besides this CI hiccup, seems alright:

Downloading archive: https://storage.googleapis.com/travis-ci-language-archives/php/binaries/ubuntu/14.04/x86_64/php-8.0.tar.bz2

0.04s$ curl -sSf --retry 5 -o archive.tar.bz2 $archive_url && tar xjf archive.tar.bz2 --directory /

curl: (22) The requested URL returned error: 404 Not Found

@Ocramius
Copy link
Contributor Author

Hmmmm no, seems like we need to upgrade the base image overall.

@Ocramius
Copy link
Contributor Author

ah yes, need to update patch to run CS tools on PHP 8.x :-)

@WyriHaximus
Copy link
Collaborator

@Ocramius FYI I started working to update to GA in #66, once this PR is in I'll enable Dependabot. Might have to ping @jwage for both

@WyriHaximus
Copy link
Collaborator

WyriHaximus commented Jan 20, 2021

@Ocramius #66 has been merged, could you rebase this PR so we can get PHP 8 support out there?

@Ocramius Ocramius force-pushed the feature/#64-php-8-support-and-dependency-bumps branch from 297a39e to ec065d6 Compare January 20, 2021 09:28
@Ocramius
Copy link
Contributor Author

@WyriHaximus I think ocular is not PHP 8-ready. Can I kill it, so we kill scrutinizer overall?

@WyriHaximus
Copy link
Collaborator

@WyriHaximus I think ocular is not PHP 8-ready. Can I kill it, so we kill scrutinizer overall?

@jwage Assuming we'd still want to coverage percentage badge in the readme? Personally, I've started replacing scrutinized with coveralls.io, suppose we can do a follow up adding coveralls or something else soon after nuking scrutinized?

@Ocramius
Copy link
Contributor Author

I'm personally dropping all of these third-party tools, replacing them with infection/infection.

I'll kill scrutinizer, for now :-)

@Ocramius
Copy link
Contributor Author

@WyriHaximus I managed to keep Scrutinizer-CI, but making it a bit more lax on failures on ocular.phar

@Ocramius
Copy link
Contributor Author

The base branch requires all commits to be signed.

OOOOOOOF.

@WyriHaximus
Copy link
Collaborator

The base branch requires all commits to be signed.

OOOOOOOF.

Do you have that set up somewhere, or do you want me or @jwage to do something about that?

@Ocramius Ocramius force-pushed the feature/#64-php-8-support-and-dependency-bumps branch from da10a6b to ae82421 Compare January 20, 2021 11:53
@Ocramius
Copy link
Contributor Author

It's a branch protection rule, but I just rebased with git rebase --exec 'git commit --amend --no-edit -n -S' -i master and entered my GPG password a few times :P

@WyriHaximus WyriHaximus merged commit 0185ce9 into jwage:master Jan 20, 2021
@WyriHaximus WyriHaximus added this to the 1.3.0 milestone Jan 20, 2021
@Ocramius Ocramius deleted the feature/#64-php-8-support-and-dependency-bumps branch January 20, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

php:~8.0.0 support
2 participants