-
Notifications
You must be signed in to change notification settings - Fork 8
Upgraded dependencies, dropped PHP < 7.3 #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded dependencies, dropped PHP < 7.3 #65
Conversation
Overall would endorse bumping dependency ranges. Also, travis-ci will probably hang forever here. |
Going to update this, and several other external packages I maintain to include Dependabot and GitHub Actions this week.
Travis now fails because |
Besides this CI hiccup, seems alright:
|
Hmmmm no, seems like we need to upgrade the base image overall. |
ah yes, need to update patch to run CS tools on PHP 8.x :-) |
297a39e
to
ec065d6
Compare
@WyriHaximus I think |
@jwage Assuming we'd still want to coverage percentage badge in the readme? Personally, I've started replacing scrutinized with coveralls.io, suppose we can do a follow up adding coveralls or something else soon after nuking scrutinized? |
I'm personally dropping all of these third-party tools, replacing them with I'll kill scrutinizer, for now :-) |
@WyriHaximus I managed to keep Scrutinizer-CI, but making it a bit more lax on failures on |
OOOOOOOF. |
Do you have that set up somewhere, or do you want me or @jwage to do something about that? |
…ble with PHP 8.x
da10a6b
to
ae82421
Compare
It's a branch protection rule, but I just rebased with |
Fixes #64