Skip to content

Upgraded dependencies, composer:^2 and php:^8, mutation tests CI improvements #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 21, 2021

Conversation

Ocramius
Copy link
Member

@Ocramius Ocramius commented Jan 11, 2021

I was mostly annoyed by the composer install time in CI environments, so I decided to give this a shot and update to php:^8 and composer/composer:^2.

TODO:

  • add CI task that performs a docker build, ensuring that our build process still runs

Blockers:

@Ocramius Ocramius added this to the 1.9.0 milestone Jan 11, 2021
@Ocramius Ocramius self-assigned this Jan 11, 2021
@Ocramius Ocramius force-pushed the feature/upgrade-dependencies branch from bfbf184 to 9bfb648 Compare January 11, 2021 18:08
@geerteltink
Copy link
Member

LGTM when the dependencies are updated. This should improve the build time a lot.

@Ocramius have you thought about building the docker container itself and push that to a registry? That way the container doesn't need to be build repeatedly and would improve speed even more. I'm not sure how that would work with actions though or if we can use GitHub registry for it. Last time I checked you could not access the GitHub registry without tokens.

@Ocramius
Copy link
Member Author

Yeah, unsure about docker builds: would be totally for it if it were globally usable 🤔

Ocramius added a commit that referenced this pull request Jan 21, 2021
@Ocramius Ocramius force-pushed the feature/upgrade-dependencies branch from c5fa101 to 46cb3e6 Compare January 21, 2021 03:48
…n't respect static analysis

This also shows mutations for only the diffs in the code, rather than running the whole
mutation test suite (expensive).

Signed-off-by: Marco Pivetta <[email protected]>
@Ocramius Ocramius force-pushed the feature/upgrade-dependencies branch from db1a414 to 0014409 Compare January 21, 2021 04:11
… commands to reference it

Signed-off-by: Marco Pivetta <[email protected]>
@Ocramius Ocramius force-pushed the feature/upgrade-dependencies branch 2 times, most recently from 7ddb958 to 831b89a Compare January 21, 2021 04:37
As per https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions,
it is possible to use the `github.<...>` context to access some information about the current action
run.

Signed-off-by: Marco Pivetta <[email protected]>
@Ocramius Ocramius force-pushed the feature/upgrade-dependencies branch from 831b89a to 27a46b0 Compare January 21, 2021 04:46
@Ocramius Ocramius force-pushed the feature/upgrade-dependencies branch from d5d9fa8 to ee66d1d Compare January 21, 2021 05:00
@Ocramius Ocramius changed the title Upgraded dependencies, running on composer:^2 and php:^8 Upgraded dependencies, running on composer:^2 and php:^8, improved mutation tests CI integration Jan 21, 2021
@Ocramius Ocramius changed the title Upgraded dependencies, running on composer:^2 and php:^8, improved mutation tests CI integration Upgraded dependencies, composer:^2 and php:^8, mutation tests CI improvements Jan 21, 2021
@Ocramius
Copy link
Member Author

Note: the added mumbojumbo around mutation-tests.yml is mostly to produce decent reports (and fast ones) for users that send patches to improve small sections of the code.

That ensures that we don't need to run the full mutation test suite against everything every time, if the diff is limited to some sources.

The output looks like this:

Selection_567

@Ocramius Ocramius force-pushed the feature/upgrade-dependencies branch from c2a18fa to c5189e2 Compare January 21, 2021 05:15
@Ocramius Ocramius merged commit 69e6fb5 into 1.9.x Jan 21, 2021
@Ocramius Ocramius deleted the feature/upgrade-dependencies branch January 21, 2021 05:17
@Ocramius
Copy link
Member Author

Just to make sure everything went smoothly, I ran this on a pre-existing tag of ocramius/LazyMap, and it works fine: https://github.com/Ocramius/LazyMap/runs/1739730760?check_suite_focus=true#step:4:12 (failure expected, since tag already exists)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants