Add API and CI codeowners #136
Conversation
Signed-off-by: npolshakova <[email protected]>
npolshakova
requested review from
ilevine,
ilrudie,
jenshu,
linsun and
yuval-k
as code owners
| - npolshakova | ||
| - timflannagan | ||
| - yuval-k | ||
| members: |
There was a problem hiding this comment.
if this is meant to be a copy of the controller-maintainers, looks like we are missing a few of the newer members (howardjohn, petrmc, ymesika)
There was a problem hiding this comment.
It shouldn't. Area based owners should be a subset of controller/kgateway maintainers who have established domain expertise in that specific area. That definitely isn't the case for API ownership here.
| privacy: closed | ||
| repos: | ||
| kgateway: maintain | ||
| kgateway-api-owners: |
There was a problem hiding this comment.
owner isn't a defined roll within the org? What does it mean to be an owner?
There was a problem hiding this comment.
this is to define a new team to be used as codeowners
There was a problem hiding this comment.
But as a project, what is an owner? How do I become one? It's not a defined role I can have. There are no qualifications but somehow folks have membership in a team that grants some privileges to them.
There was a problem hiding this comment.
yes, i think we don't yet have a clear definition of this role and how one would get into this group
There was a problem hiding this comment.
In Istio, we have nested maintainer roles such as networking/ztunnel. Every ztunnel maintainer is a networking maintainer but not every networking maintainer is a ztunnel maintainer. Is this essentially meant to be nested like that? If you are a kgw maintainer you can also be a kgw/api maintainer for example?
There was a problem hiding this comment.
yeah i think it's reasonable that "kgateway api maintainer" would be a subset of "kgateway controller maintainer".
if we are calling this a new "maintainer" group then do we also need to have a formal process that's documented in https://github.com/kgateway-dev/community/blob/main/CONTRIBUTOR_LADDER.md#maintainer? in Istio how does one become a ztunnel maintainer for example?
There was a problem hiding this comment.
Something like controller/api makes sense to me. I don't think we need a specific ladder per se. If you qualify to be controller/api you should naturally meet the qualifications of the more general controller I'd suspect. Do we imagine this won't be the case?
There was a problem hiding this comment.
I was more asking the other way around - if you are already a (more general) controller maintainer, what extra qualifications do you need to become a controller api maintainer?
There was a problem hiding this comment.
Oh, I see. Enough pr/reviews/knowledge/involvement in the API area. Trust of the other API maintainers.
|
@npolshakova can we close this since you have #138 open? |
4 participants
Creates two new codeowners groups for CI and API.