Skip to content

Add initial codeowner groups #12635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jenshu merged 6 commits into from
Dec 16, 2025
Merged

Add initial codeowner groups #12635

jenshu merged 6 commits into from
Dec 16, 2025

Conversation

@npolshakova
Copy link
Contributor

@npolshakova npolshakova commented Oct 15, 2025 •
edited by timflannagan
Loading

Description

Add initial code owner groups for API Maintainers and Owners for CI

Change Type

/kind cleanup

Changelog

Added codeowners for kgateway for API maintainers and CI maintainers.

Copilot AI review requested due to automatic review settings October 15, 2025 17:41
Copilot AI reviewed Oct 15, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new CODEOWNERS file to establish code ownership groups for the kgateway project, implementing automated review requirements for critical components.

  • Adds code ownership rules for API-related files and CI infrastructure
  • Establishes two ownership groups: API owners and CI owners
  • Sets up automated review requirements for critical paths like /api/, /install/, .github/, and Go modules

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added kind/feature Categorizes issue or PR as related to a new feature. release-note labels Oct 15, 2025
ashleywang1
ashleywang1 reviewed Oct 15, 2025
View reviewed changes
jenshu
jenshu reviewed Oct 15, 2025
View reviewed changes
@npolshakova
Copy link
Contributor Author

npolshakova commented Oct 23, 2025

Community PR to introduce groups: kgateway-dev/community#136

@shashankram shashankram added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is still being worked on or has unresolved issues label Oct 24, 2025
@shashankram
Copy link
Contributor

shashankram commented Oct 24, 2025

More granular code ownership and reviewer assignment is definitely required, though I'd like to explore a different mechanism than file based code ownership. Let's discuss this before merging this.

@github-actions github-actions bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Oct 27, 2025
@timflannagan timflannagan mentioned this pull request Oct 29, 2025
Closed
@npolshakova
initial codeowner groups
74bf968 
Signed-off-by: npolshakova <[email protected]>
@npolshakova
more ci workflow approval files
3782a38 
Signed-off-by: npolshakova <[email protected]>
@npolshakova
fix name
3be46e9 
Signed-off-by: npolshakova <[email protected]>
@npolshakova
feedback
ba061d3 
Signed-off-by: npolshakova <[email protected]>
@npolshakova
only api owners
9ed8a40 
Signed-off-by: npolshakova <[email protected]>
@npolshakova npolshakova removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is still being worked on or has unresolved issues label Dec 3, 2025
@npolshakova
Copy link
Contributor Author

npolshakova commented Dec 3, 2025

community pr to introduce groups: kgateway-dev/community#138

jenshu
jenshu reviewed Dec 16, 2025
View reviewed changes
@jenshu
update team name
adb1e5c 
Signed-off-by: Jenny Shu <[email protected]>
timflannagan
timflannagan approved these changes Dec 16, 2025
View reviewed changes
CODEOWNERS
# See: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

# API definitions and CRDs - critical for kgateway API compatibility
/api/v1alpha1/kgateway @kgateway-dev/kgateway-api-owners
Copy link
Member

@timflannagan timflannagan Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, the UI is complaining this group doesn't exist, but https://github.com/orgs/kgateway-dev/teams/kgateway-api-owners does. Maybe it's just lagging a bit behind.

Copy link
Contributor

@jenshu jenshu Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird i don't see that? are you viewing this through a browser?

@jenshu jenshu enabled auto-merge December 16, 2025 17:00
@jenshu jenshu added this pull request to the merge queue Dec 16, 2025
Merged via the queue into kgateway-dev:main with commit 4c28b7c Dec 16, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashleywang1 ashleywang1 ashleywang1 left review comments

@jenshu jenshu jenshu left review comments

Copilot code review Copilot Copilot left review comments

@timflannagan timflannagan timflannagan approved these changes

@puertomontt puertomontt Awaiting requested review from puertomontt

@shashankram shashankram Awaiting requested review from shashankram

Assignees

No one assigned

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@npolshakova @shashankram @ashleywang1 @timflannagan @jenshu