Mock (<= v6.6) relies on existing resolv.conf with --hermetic-build#118
Merged
praiskup merged 1 commit intokonflux-ci:mainfrom Jan 29, 2026
Merged
Mock (<= v6.6) relies on existing resolv.conf with --hermetic-build#118praiskup merged 1 commit intokonflux-ci:mainfrom
praiskup merged 1 commit intokonflux-ci:mainfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a workaround for an issue where mock versions up to 6.6 require /etc/resolv.conf to exist, even during a hermetic build. The change correctly creates this file. I've suggested adding a comment to document the reason for this workaround, which will improve maintainability.
Containerfile
Outdated
| # Assert utility versions | ||
| RUN test "$(rpm --eval '%[ v"'"$(rpm -q --qf '%{VERSION}\n' mock)"'" >= v"6.4" ]')" = "1" | ||
|
|
||
| RUN touch /etc/resolv.conf |
There was a problem hiding this comment.
For better maintainability, it's good practice to add a comment explaining why this touch command is necessary. It provides valuable context for future developers, clarifying that this is a workaround for a specific version range of the mock tool.
# Mock (<= v6.6) relies on existing resolv.conf with --hermetic-build
# See: https://bugzilla.redhat.com/show_bug.cgi?id=2433808
# See: https://github.com/rpm-software-management/mock/pull/1697
RUN touch /etc/resolv.conf
praiskup
added a commit
to praiskup/rpmbuild-pipeline-environment-container
that referenced
this pull request
Jan 29, 2026
praiskup
force-pushed
the
praiskup-resolv.conf
branch
from
d658b84 to
a4a1bef
Compare
praiskup
force-pushed
the
praiskup-resolv.conf
branch
from
a4a1bef to
1effaa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=2433808
Related: rpm-software-management/mock#1697