mock: disable networking in bootstrap for hermetic builds #1697
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/packit test |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request disables networking for the bootstrap phase of hermetic builds by updating the hermetic-build.cfg file. The changes set rpmbuild_networking and use_host_resolv to False for the bootstrap configuration, which is the correct approach to enforce network isolation. The change is clear, correct, and improves the hermeticity of the build process. I have no further feedback.
praiskup
added a commit
to praiskup/rpmbuild-pipeline-environment-container
that referenced
this pull request
Jan 29, 2026
praiskup
added a commit
to praiskup/rpmbuild-pipeline-environment-container
that referenced
this pull request
Jan 29, 2026
xsuchy
reviewed
Jan 29, 2026
| mount_point = BindMountPoint(srcpath=key_dir, bindpath=chroot_dir) | ||
| bootstrap_buildroot.mounts.add(mount_point) | ||
|
|
||
| util.setup_host_resolv(bootstrap_buildroot_config) |
Member
There was a problem hiding this comment.
Hmm. But plugins and bindmountpoint will not have a functional resolv.conf.
praiskup
added a commit
to praiskup/rpmbuild-pipeline-environment-container
that referenced
this pull request
Jan 29, 2026
praiskup
added a commit
to praiskup/rpmbuild-pipeline-environment-container
that referenced
this pull request
Jan 29, 2026
praiskup
added a commit
to konflux-ci/rpmbuild-pipeline-environment-container
that referenced
this pull request
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.