Skip to content

koordlet: cleanup runtimehooks and remove the unused code.#1208

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
xigang:cleanup
Apr 11, 2023
Merged

koordlet: cleanup runtimehooks and remove the unused code.#1208
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
xigang:cleanup

Conversation

@xigang
Copy link
Contributor

@xigang xigang commented Apr 11, 2023

Ⅰ. Describe what this PR does

koordlet: cleanup runtimehooks code and remove the unused code

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: xigang <wangxigang2014@gmail.com>
@xigang xigang changed the title koordlet: cleanup runtimehooks code and remove the unused code. koordlet: cleanup runtimehooks and remove the unused code. Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (0c38b28) 65.73% compared to head (ef1e0ca) 65.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1208      +/-   ##
==========================================
+ Coverage   65.73%   65.74%   +0.01%     
==========================================
  Files         290      290              
  Lines       30647    30646       -1     
==========================================
+ Hits        20145    20148       +3     
+ Misses       9023     9020       -3     
+ Partials     1479     1478       -1     
Flag Coverage Δ
unittests 65.74% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/runtimehooks.go 74.07% <0.00%> (+0.90%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hormes
Copy link
Member

hormes commented Apr 11, 2023

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit fdeadb0 into koordinator-sh:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants