Skip to content

koordlet: cleanup runtimehooks and remove the unused code. #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koordinator-bot merged 1 commit into from
Apr 11, 2023
Merged

koordlet: cleanup runtimehooks and remove the unused code. #1208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/koordlet/runtimehooks/hooks/hooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ func Register(stage rmconfig.RuntimeHookType, name, description string, hookFn H
h, err := generateNewHook(stage, name)
if err != nil {
klog.Fatalf("hook %s register failed, reason: %v", name, err)
return h
}
klog.V(1).Infof("hook %s is registered", name)
h.description = description
Expand Down
3 changes: 1 addition & 2 deletions pkg/koordlet/runtimehooks/rule/rule.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ var globalRWMutex sync.RWMutex
func Register(name, description string, injectOpts ...InjectOption) *Rule {
r, exist := find(name)
if exist {
klog.Fatalf("rule %s is conflict since name is already registered")
return r
klog.Fatalf("rule %s is conflict since name is already registered", r.name)
}
r.description = description
for _, opt := range injectOpts {
Expand Down
5 changes: 3 additions & 2 deletions pkg/koordlet/runtimehooks/runtimehooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ limitations under the License.
package runtimehooks

import (
"fmt"

"k8s.io/klog/v2"

"github.com/koordinator-sh/koordinator/pkg/features"
Expand Down Expand Up @@ -109,8 +111,7 @@ func NewRuntimeHook(si statesinformer.StatesInformer, cfg *Config) (RuntimeHook,
"Update hooks rule if NodeTopology infor update",
rule.UpdateRules)
if err := s.Setup(); err != nil {
klog.Fatal("failed to setup runtime hook server, error %v", err)
return nil, err
return nil, fmt.Errorf("failed to setup runtime hook server, error %v", err)
}
return r, nil
}
Expand Down