Skip to content

scheduler: pick vf by random#1953

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZiMengSheng:randomvf
Mar 14, 2024
Merged

scheduler: pick vf by random#1953
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZiMengSheng:randomvf

Conversation

@ZiMengSheng
Copy link
Member

@ZiMengSheng ZiMengSheng commented Mar 14, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.53%. Comparing base (a85121a) to head (848c2a8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1953   +/-   ##
=======================================
  Coverage   67.52%   67.53%           
=======================================
  Files         420      420           
  Lines       47040    47040           
=======================================
+ Hits        31766    31769    +3     
+ Misses      12963    12960    -3     
  Partials     2311     2311           
Flag Coverage Δ
unittests 67.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koordinator-bot koordinator-bot bot merged commit beaafa3 into koordinator-sh:main Mar 14, 2024
ZiMengSheng pushed a commit to ZiMengSheng/koordinator that referenced this pull request Apr 9, 2024
This reverts commit beaafa3.

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
koordinator-bot bot pushed a commit that referenced this pull request Apr 9, 2024
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
georgexiang pushed a commit to ocichina/koordinator that referenced this pull request Apr 15, 2024
…tor-sh#1986)

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Signed-off-by: george <xiangzhihua@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants